Review main Merged

73605[BUGFIX] Fix undefined array key in TextTableElement

Nikita Hovratov CR +2 V +2 Easy +2 −1 updated 02/20/22, 00:46

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Nikita Hovratov uploaded patch set 1 02/19/22, 17:18

  2. core-ci voted on patch set 1 V +1 02/19/22, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23906

  3. Oliver Klee commented on patch set 1 02/19/22, 22:01

    TextTableElement.php:106

    If find it really hard to wrap my head around this nested combination of the ?? and ?: operator. I propose we split this into two statement, potentially involving a new, well-named local variable.
  4. Nikita Hovratov uploaded patch set 2 02/19/22, 22:05

  5. Nikita Hovratov commented on patch set 2 02/19/22, 22:05

    TextTableElement.php:106 Reply

    Done
  6. core-ci voted on patch set 2 V +1 02/19/22, 22:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23913

  7. Benjamin Franzke voted on patch set 2 V +1 CR +1 02/19/22, 22:15

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 02/19/22, 23:40

  9. Benjamin Franzke voted on patch set 2 V +2 CR +2 02/20/22, 00:46

  10. Benjamin Franzke merged patch set 3 02/20/22, 00:46