Review main Merged

73606[BUGFIX] Show CSH popup window without backend frame

Benjamin Franzke CR +2 V +2 Easy +32 −13 updated 02/20/22, 12:24

Commit message

Since #94084 all module URLs are automatically framed by
the TYPO3 main controller whenever they are opened
in a Sec-Fetch-Dest aware request.

Use a non-module route for the popup window in order
to avoid the automatic re-framing.

Also hide the back-button in the popup window, as it would
cause the entire backend to be opened in the popup.
The shortcut button will link to the module-based
detail-action in order to show in regular module context.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 1012

  1. Benjamin Franzke uploaded patch set 1 02/19/22, 17:18

  2. core-ci voted on patch set 1 V +1 02/19/22, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23907

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 02/19/22, 23:48

  4. Christian Kuhn commented on patch set 1 02/20/22, 08:36

    i'm unable to reproduce #95361 - the popup works fine for me and shows the help content, even without the patch. is there a trick, do i need to use https or something?
  5. Benjamin Franzke commented on patch set 1 02/20/22, 11:48

    Reply

    yea, you need to use a context that is assumed secure by the browser for the related Sec-Fetch-Dest (#94084) thingy to take effect, so either: * https url or * http://*.localhost (in chrome)
  6. Christian Kuhn uploaded patch set 2 02/20/22, 12:01

  7. Christian Kuhn commented on patch set 2 V +1 CR +1 02/20/22, 12:05

    Reply

    a *.localhost did the trick. thx.

    HelpController.php:89

    obsolete second argument.
  8. Nikita Hovratov commented on patch set 2 V +1 CR +1 02/20/22, 12:16

    Nice, finally its fixed :)
  9. Andreas Kienast voted on patch set 2 V +2 CR +2 02/20/22, 12:19

  10. Stefan Bürk voted on patch set 2 V +1 CR +1 02/20/22, 12:23

  11. core-ci voted on patch set 2 V +1 02/20/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23935

  12. Andreas Kienast merged patch set 3 02/20/22, 12:24