73606[BUGFIX] Show CSH popup window without backend frame
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 3
Files 5
- Build/Sources/TypeScript/backend/context-help.ts+3 −6
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −1
- typo3/sysext/backend/Classes/Controller/HelpController.php1+21 −5
- typo3/sysext/backend/Configuration/Backend/Routes.php+6 −0
- typo3/sysext/backend/Resources/Public/JavaScript/context-help.js+1 −1
Review log 1012
-
Benjamin Franzke uploaded patch set 1 02/19/22, 17:18
-
core-ci voted on patch set 1 V +1 02/19/22, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23907
-
Stefan Bürk voted on patch set 1 V +1 CR +1 02/19/22, 23:48
-
Christian Kuhn commented on patch set 1 02/20/22, 08:36
i'm unable to reproduce #95361 - the popup works fine for me and shows the help content, even without the patch. is there a trick, do i need to use https or something? -
Benjamin Franzke commented on patch set 1 02/20/22, 11:48
Reply
yea, you need to use a context that is assumed secure by the browser for the related Sec-Fetch-Dest (#94084) thingy to take effect, so either: * https url or * http://*.localhost (in chrome) -
Christian Kuhn uploaded patch set 2 02/20/22, 12:01
-
Christian Kuhn commented on patch set 2 V +1 CR +1 02/20/22, 12:05
Reply
a *.localhost did the trick. thx.HelpController.php:89obsolete second argument. -
Nikita Hovratov commented on patch set 2 V +1 CR +1 02/20/22, 12:16
Nice, finally its fixed :) -
Andreas Kienast voted on patch set 2 V +2 CR +2 02/20/22, 12:19
-
Stefan Bürk voted on patch set 2 V +1 CR +1 02/20/22, 12:23
-
core-ci voted on patch set 2 V +1 02/20/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23935
-
Andreas Kienast merged patch set 3 02/20/22, 12:24