Review 11.5 Merged

73608[BUGFIX] Show CSH popup window without backend frame

Benjamin Franzke CR +2 V +2 Easy +21 −14 updated 02/20/22, 12:46

Commit message

Since #94084 all module URLs are automatically framed by
the TYPO3 main controller whenever they are opened
in a Sec-Fetch-Dest aware request.

Use a non-module route for the popup window in order
to avoid the automatic re-framing.

Also hide the back-button in the popup window, as it would
cause the entire backend to be opened in the popup.
The shortcut button will link to the module-based
detail-action in order to show in regular module context.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 3

Files 5

Review log 45

  1. Benjamin Franzke uploaded patch set 1 02/19/22, 17:32

  2. core-ci voted on patch set 1 V +1 02/19/22, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23909

  3. Benjamin Franzke marked it work in progress 02/19/22, 21:46

  4. Benjamin Franzke commented on patch set 1 V +2 CR +2 02/20/22, 12:46

    This change is ready for review.
  5. Benjamin Franzke merged patch set 2 02/20/22, 12:46