73615[FEATURE] Add two new PSR-14 events to Site Configuration
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Classes/Configuration/Event/SiteConfigurationBeforeWriteEvent.phpnew+49 −0
- typo3/sysext/core/Classes/Configuration/Event/SiteConfigurationLoadedEvent.phpnew+49 −0
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+12 −4
- typo3/sysext/core/Classes/ServiceProvider.php+1 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96975-NewPSR-14EventsForSiteConfiguration.rst12new+49 −0
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+3 −1
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.php+3 −1
- typo3/sysext/core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php+3 −0
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+4 −0
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+16 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+21 −4
Review log 2431
Show 56 earlier messages
-
Susi Moog uploaded patch set 1 02/20/22, 12:05
-
core-ci voted on patch set 1 V +1 02/20/22, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23936
-
Andreas Kienast voted on patch set 1 CR +1 02/20/22, 12:42
-
Benjamin Franzke commented on patch set 1 02/20/22, 13:59
Feature-96975-NewPSR-14EventsForSiteConfiguration.rst:13remove parentheses, as the message after "and" has the same entropy and both belonging together. -
Guido Schmechel commented on patch set 1 02/20/22, 15:20
Already successfully tested!Feature-96975-NewPSR-14EventsForSiteConfiguration.rst:1Do we need here maybe a small example for the EventListener registration and for example how to change the websiteTitle? -
Susi Moog uploaded patch set 2 02/21/22, 07:16
-
Susi Moog commented on patch set 2 02/21/22, 07:18
Services.yaml:51ReplyThanks, done.Feature-96975-NewPSR-14EventsForSiteConfiguration.rst:1ReplyAdded an example for the registration itself, IMHO that should be understandable enough :) Thanks.Feature-96975-NewPSR-14EventsForSiteConfiguration.rst:13ReplyDone -
core-ci voted on patch set 2 V +1 02/21/22, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23964
-
Jörg Bösche voted on patch set 2 CR +1 02/21/22, 07:30
-
Chris Müller commented on patch set 2 02/21/22, 07:32
Feature-96975-NewPSR-14EventsForSiteConfiguration.rst:35Services.yaml, with capital SFeature-96975-NewPSR-14EventsForSiteConfiguration.rst:44"event" is not needed anymore since v11.Feature-96975-NewPSR-14EventsForSiteConfiguration.rst:49"event" is not needed anymore since v11. -
Benni Mack commented on patch set 2 02/21/22, 07:36
good some good use-cases for them? -
Susi Moog commented on patch set 2 02/21/22, 08:35
Reply
Don't know about "good" use cases, at the moment, the whole site configuration is hardly extensible at all, this is my way of making it possible. There are multiple things one could achieve that I don't necessarily see as core features: - Implement a thin layer allowing fields with names like `settings.foo` to be edited in the gui and written to the settings part. - Implement automatic set up of site settings for theme packages / template-based projects on first write - Inject settings into configuration from a third party configuration storage - Trigger additional processes whenever a site configuration is changed (review notifications, auto-setups...)Feature-96975-NewPSR-14EventsForSiteConfiguration.rst:49Replyyes, but if I leave that out here, then the example needs to show the complete implementation code and the event is afaik only unnecessary if the listener only listens to one event (so there are cases where this is still valid and I think for the documentation understandability of this use case it's clearer this way) - but it's not a hill I'm willing to die on ;) so feel free to adjust this to something that is clearer to you :) -
Susi Moog commented on patch set 3 02/21/22, 08:35
Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 02/21/22, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23968
-
Susi Moog uploaded patch set 4 03/02/22, 09:55
-
core-ci voted on patch set 4 V +1 03/02/22, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24443
-
Benni Mack commented on patch set 4 CR +1 03/02/22, 14:07
Feature-96975-NewPSR-14EventsForSiteConfiguration.rst:35ReplyDone -
Benni Mack commented on patch set 4 03/02/22, 21:30
Feature-96975-NewPSR-14EventsForSiteConfiguration.rst:49Reply@chris: care to update the patch? -
Susi Moog commented on patch set 4 04/08/22, 08:07
@chris will you update the patch? otherwise I'd like to use it like this. -
Chris Müller uploaded patch set 5 04/08/22, 08:24
-
Chris Müller commented on patch set 5 04/08/22, 08:25
Feature-96975-NewPSR-14EventsForSiteConfiguration.rst:44ReplyDoneFeature-96975-NewPSR-14EventsForSiteConfiguration.rst:49ReplyDone -
Chris Müller uploaded patch set 6 04/08/22, 08:31
-
core-ci voted on patch set 5 V -1 04/08/22, 08:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25813
-
core-ci voted on patch set 6 V +1 04/08/22, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25815
-
Susi Moog commented on patch set 6 04/12/22, 15:36
Thanks Chris. -
Stefan Bürk commented on patch set 6 CR -1 04/12/22, 15:56
on it -
Stefan Bürk uploaded patch set 7 04/12/22, 16:05
-
core-ci voted on patch set 7 V +1 04/12/22, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25959
-
Stefan Bürk voted on patch set 7 V +1 CR +1 04/12/22, 17:18
-
Benni Mack voted on patch set 7 V +2 CR +2 04/17/22, 19:46
-
Benni Mack merged patch set 8 04/17/22, 19:46
Services.yaml:51