73616[BUGFIX] Disallow negative periods in recycler scheduler task
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Guido Schmechel +1
- Stefan Bürk +1
- Christian Kuhn +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Andreas Kienast +2
- Guido Schmechel +1
- Stefan Bürk +1
- Christian Kuhn +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2024
-
Andreas Kienast uploaded patch set 1 02/20/22, 13:07
-
core-ci voted on patch set 1 V -1 02/20/22, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23939
-
Andreas Kienast uploaded patch set 2 02/20/22, 13:21
-
core-ci voted on patch set 2 V +1 02/20/22, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23941
-
Nikita Hovratov commented on patch set 2 02/20/22, 13:47
double negative -
Andreas Kienast commented on patch set 2 02/20/22, 14:00
Reply
Ack -
Andreas Kienast updated the commit message in patch set 3 02/20/22, 14:00
-
Guido Schmechel voted on patch set 3 V +1 CR +1 02/20/22, 14:02
-
core-ci voted on patch set 3 V +1 02/20/22, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23943
-
Nikita Hovratov voted on patch set 3 V +1 CR +1 02/20/22, 14:48
-
Stefan Bürk commented on patch set 3 02/20/22, 14:55
CleanerFieldProvider.php:175Would suggest to do this as following: ``` $period = filter_var($period, FILTER_VALIDATE_INT); if ($period !== false && $period > 0) { ... } ``` The empty() check here is superflous, as empty(0) or empty("0") would be true, thus we can skip this here and simple use the filter_var() to check if we have a real int with either false or the int conversion and check for the > 0 then. Simplifies this and removes the magic empty() method from the check here with the unknown behavour for most developers. I know, the empty check was there before - but if we change this now, let us change this along the way. Would you be fine with this ? -
Nikita Hovratov commented on patch set 3 02/20/22, 15:12
CleanerFieldProvider.php:175Reply+1 good idea -
Nikita Hovratov voted on patch set 3 V 0 CR 0 02/20/22, 15:15
-
Guido Schmechel wrote 02/20/22, 15:21
Removed Verified+1 by Guido Schmechel <guido.schmechel@brandung.de> -
Guido Schmechel wrote 02/20/22, 15:21
Removed Code-Review+1 by Guido Schmechel <guido.schmechel@brandung.de> -
Andreas Kienast commented on patch set 3 02/20/22, 15:43
CleanerFieldProvider.php:175ReplyAck -
Andreas Kienast uploaded patch set 4 02/20/22, 15:43
-
Stefan Bürk voted on patch set 4 V +1 CR +1 02/20/22, 15:45
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 02/20/22, 15:49
-
core-ci voted on patch set 4 V +1 02/20/22, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23946
-
Christian Kuhn voted on patch set 4 V +1 CR +1 02/20/22, 20:11
-
Guido Schmechel voted on patch set 4 V +1 CR +1 02/20/22, 21:27
-
Andreas Kienast voted on patch set 4 V +2 CR +2 02/21/22, 07:54
-
Andreas Kienast merged patch set 5 02/21/22, 07:54