Review main Merged

73616[BUGFIX] Disallow negative periods in recycler scheduler task

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 02/21/22, 07:54

Commit message

The period validation now also checks whether the input is larger than
0 to disallow negative values.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Guido Schmechel +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Guido Schmechel +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2024

  1. Andreas Kienast uploaded patch set 1 02/20/22, 13:07

  2. core-ci voted on patch set 1 V -1 02/20/22, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23939

  3. Andreas Kienast uploaded patch set 2 02/20/22, 13:21

  4. core-ci voted on patch set 2 V +1 02/20/22, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23941

  5. Nikita Hovratov commented on patch set 2 02/20/22, 13:47

    double negative
  6. Andreas Kienast commented on patch set 2 02/20/22, 14:00

    Reply

    Ack
  7. Andreas Kienast updated the commit message in patch set 3 02/20/22, 14:00

  8. Guido Schmechel voted on patch set 3 V +1 CR +1 02/20/22, 14:02

  9. core-ci voted on patch set 3 V +1 02/20/22, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23943

  10. Nikita Hovratov voted on patch set 3 V +1 CR +1 02/20/22, 14:48

  11. Stefan Bürk commented on patch set 3 02/20/22, 14:55

    CleanerFieldProvider.php:175

    Would suggest to do this as following: ``` $period = filter_var($period, FILTER_VALIDATE_INT); if ($period !== false && $period > 0) { ... } ``` The empty() check here is superflous, as empty(0) or empty("0") would be true, thus we can skip this here and simple use the filter_var() to check if we have a real int with either false or the int conversion and check for the > 0 then. Simplifies this and removes the magic empty() method from the check here with the unknown behavour for most developers. I know, the empty check was there before - but if we change this now, let us change this along the way. Would you be fine with this ?
  12. Nikita Hovratov commented on patch set 3 02/20/22, 15:12

    CleanerFieldProvider.php:175 Reply

    +1 good idea
  13. Nikita Hovratov voted on patch set 3 V 0 CR 0 02/20/22, 15:15

  14. Guido Schmechel wrote 02/20/22, 15:21

    Removed Verified+1 by Guido Schmechel <guido.schmechel@brandung.de>
  15. Guido Schmechel wrote 02/20/22, 15:21

    Removed Code-Review+1 by Guido Schmechel <guido.schmechel@brandung.de>
  16. Andreas Kienast commented on patch set 3 02/20/22, 15:43

    CleanerFieldProvider.php:175 Reply

    Ack
  17. Andreas Kienast uploaded patch set 4 02/20/22, 15:43

  18. Stefan Bürk voted on patch set 4 V +1 CR +1 02/20/22, 15:45

  19. Nikita Hovratov voted on patch set 4 V +1 CR +1 02/20/22, 15:49

  20. core-ci voted on patch set 4 V +1 02/20/22, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23946

  21. Christian Kuhn voted on patch set 4 V +1 CR +1 02/20/22, 20:11

  22. Guido Schmechel voted on patch set 4 V +1 CR +1 02/20/22, 21:27

  23. Andreas Kienast voted on patch set 4 V +2 CR +2 02/21/22, 07:54

  24. Andreas Kienast merged patch set 5 02/21/22, 07:54