Review main Merged

73617[TASK] Use number field for period configuration in recycler scheduler task

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 02/21/22, 12:02

Commit message

For a better UX, the period configuration field in the "Remove deleted
records" task should be changed to be a "number" field.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Guido Schmechel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Guido Schmechel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 02/20/22, 13:14

  2. core-ci voted on patch set 1 V +1 02/20/22, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23940

  3. Guido Schmechel voted on patch set 1 V +1 CR +1 02/20/22, 14:00

  4. Benni Mack voted on patch set 1 V +1 CR +1 02/21/22, 10:24

  5. Stefan Bürk commented on patch set 1 02/21/22, 12:01

    one note. The "min" settings only controlls when the value is changed with the spinner (up/down). So user are "still" able to enter `0` or even negative numbers `-1`. Additional it is possible to "enter" decimal values - which do not make any sense. And on german browser/installation a "-1.00" gets converted to "-1,00". I know there was/is another patch to validate that. From my perspective this approach is still half-baked. As far as I know there is no native html way for this, but maybe we need some js mixin here to help out preventing invalid/negative numbers in that field ? AS this is a task and not a "bugfix" I think we should at least discuss if we should take this half-baked solution or tighten this further.
  6. Oli Bartsch voted on patch set 1 V +2 CR +2 02/21/22, 12:02

  7. Oli Bartsch merged patch set 2 02/21/22, 12:02