Review 11.5 Merged

73624[BUGFIX] Fix session update with backend "Stay logged in" button

Benjamin Franzke CR +2 V +2 Easy +12 −6 updated 02/21/22, 08:32

Commit message

For unknown reasons the /ajax/login/refresh
route has never been used (all the way back to v6),
to request a session timeout update.

Instead the route /ajax/login/timedout, *without* the
skipSessionUpdate=1 parameter has been used to
refresh an existing session.

With the introduction of configurable route parameters
in #81409 this inconsistency wasn't noticed and the
skipSessionUpdate parameter has been moved into the
route-configuration, which meant /ajax/login/timedout was
always called with skipSessionUpdate=1,
even as result of the "Stay logged in" button, where
a session update was intended.

Use the dedicated /ajax/login/refresh route
in order to actually refresh the session.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 56

  1. Benjamin Franzke uploaded patch set 1 02/21/22, 08:19

  2. Benjamin Franzke marked it ready for review 02/21/22, 08:22

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 02/21/22, 08:29

  4. core-ci voted on patch set 1 V +1 02/21/22, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23966

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 02/21/22, 08:32

  6. Benjamin Franzke merged patch set 2 02/21/22, 08:32