Review 10.4 Merged

73628[TASK] Upgrade enshrined/svg-sanitize to ^0.15.4

Oliver Hader CR +2 V +2 Easy +12 −17 updated 02/21/22, 13:33

Commit message

Recent release of enshrined/svg-sanitize addressed a XSS vulnerability.

The main purpose of having this library in TYPO3 is to protect against
user submitted images that contains markup - which is possible with
SVG files. In most TYPO3 scenarios these files would be stored in
https://example.org/fileadmin/evil.svg and can be fetched directly.

However, recent update for CVE-2022-23638 of the svg-sanitizer library
seems to address the usage of inline SVG, used in an embedded HTML
context, see https://github.com/darylldoyle/svg-sanitizer/issues/71

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 45

  1. Oliver Hader uploaded patch set 1 02/21/22, 10:02

  2. core-ci voted on patch set 1 V +1 02/21/22, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23972

  3. Oliver Hader voted on patch set 1 CR -1 02/21/22, 11:40

  4. Oliver Hader voted on patch set 1 V +2 CR +2 02/21/22, 13:31

  5. Oliver Hader merged patch set 2 02/21/22, 13:33