73631[TASK] Allow DI for extbase validators
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 5
- Bug #96332Dependency injection not working for extbase validators
- Task #92238Avoid usage of object manager in validation related classes
- Task #95026[TASK] Add missing breaking.rst about service injection in Extbase validators
- Task #94451Avoid ObjectManager in ext:extbase
- Task #94384Avoid ObjectManager in remaining ext:form places
Files 22
- Build/phpstan/phpstan-baseline.neon+20 −0
- typo3/sysext/core/Documentation/Changelog/11.0/Breaking-92238-ServiceInjectionInExtbaseValidators.rst+9 −2
- typo3/sysext/core/Documentation/Changelog/11.5.x/Important-96332-ExtbaseValidatorsCanUseDependencyInjection.rstnew+143 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+18 −15
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractCompositeValidator.php+35 −27
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractValidator.php+34 −26
- typo3/sysext/extbase/Classes/Validation/Validator/ValidatorInterface.php+16 −0
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+9 −1
- typo3/sysext/extbase/Tests/Fixture/ValidatorThatDoesNotImplementValidatorInterfaceValidator.phpdeleted+0 −25
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/AnotherModel.phprenamed+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/Model.phprenamed+3 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Validation/Validator/CustomNotInjectableValidator.phpcopied+8 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Validation/Validator/CustomValidator.phpnew+57 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Configuration/Services.yamlnew+12 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/ext_emconf.phpnew+21 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Fixture/Controller/TestController.phpdeleted+0 −30
- typo3/sysext/extbase/Tests/Functional/Validation/Fixture/Domain/Validator/ModelValidator.phpdeleted+0 −33
- typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php+36 −15
- typo3/sysext/extbase/Tests/Unit/Validation/Fixtures/Validation/Validator/CustomValidator.phprenamed+1 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Fixtures/Validation/Validator/CustomValidatorThatDoesNotImplementValidatorInterfaceValidator.phprenamed+1 −4
Review log 1317
-
Christian Kuhn uploaded patch set 1 02/21/22, 17:30
-
Christian Kuhn updated the commit message in patch set 2 02/21/22, 17:34
-
core-ci voted on patch set 1 V +1 02/21/22, 17:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23998
-
core-ci voted on patch set 2 V +1 02/21/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24000
-
Christian Kuhn uploaded patch set 3 02/21/22, 18:23
-
core-ci voted on patch set 3 V +1 02/21/22, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24006
-
Stefan Bürk voted on patch set 3 CR +1 02/21/22, 18:38
-
Stefan Bürk voted on patch set 3 V +1 02/21/22, 18:39
-
Benni Mack voted on patch set 3 V +1 CR +1 02/21/22, 19:33
-
Oli Bartsch voted on patch set 3 V +1 02/21/22, 21:49
-
Christian Kuhn uploaded patch set 4 02/22/22, 08:14
-
core-ci voted on patch set 4 V +1 02/22/22, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24031
-
Benni Mack voted on patch set 4 V +1 CR +1 02/22/22, 08:30
-
Oli Bartsch voted on patch set 4 V +1 CR +1 02/22/22, 08:33
-
Christian Kuhn voted on patch set 4 V +2 CR +2 02/22/22, 08:36
-
Stefan Bürk voted on patch set 4 V +1 CR +1 02/22/22, 08:38
-
Christian Kuhn merged patch set 5 02/22/22, 08:40