Review main Merged

73634[TASK] Set "TSFE->requestedId" early in the process

Benni Mack CR +2 V +2 Easy +5 −8 updated 02/22/22, 07:10

Commit message

The property "TSFE->requestedId" contains the
ID of the page that was initially requested.

Due to Site Handling and native URL Routing
since TYPO3 v9, this variable can be set initially
and not within determineId() / fetch_the_id(),
thus much earlier.

This way the property has no side-effects
when using $tsfe->getRequestedId() and just returns
the property as set in the constructor / setPageArguments().

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 02/21/22, 19:46

  2. core-ci voted on patch set 1 V +1 02/21/22, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24008

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 02/21/22, 20:00

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 02/22/22, 04:01

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 02/22/22, 07:10

  6. Benjamin Franzke merged patch set 2 02/22/22, 07:10