73636[BUGFIX] Use proper Postgres types on inserting / updating rows
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 7
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+2 −2
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+4 −2
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizePageAndUpdateRecordWithMinorChangesInFullRetrievedRecord.csvnew+25 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+15 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php+16 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+5 −4
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+5 −4
Review log 1014
-
Stefan Bürk uploaded patch set 1 02/21/22, 21:47
-
Stefan Bürk updated the commit message in patch set 2 02/21/22, 21:57
-
core-ci voted on patch set 1 V +1 02/21/22, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24015
-
Stefan Bürk updated the commit message in patch set 3 02/21/22, 22:03
-
core-ci voted on patch set 2 V +1 02/21/22, 22:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24016
-
core-ci voted on patch set 3 V +1 02/21/22, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24017
-
Benni Mack voted on patch set 3 V +1 CR +1 02/21/22, 22:46
-
Stefan Bürk uploaded patch set 4 02/22/22, 02:33
-
core-ci voted on patch set 4 V +1 02/22/22, 02:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24021
-
Stefan Bürk commented on patch set 4 02/22/22, 02:47
Added one testcase as requests in slack by Oliver Bartsch (thanks for nailing me on this). This testcase only covers the change in DataHandler for now. If the change is reverted the test failes with the message that the expected dataset do not match. This is basicly correct, but we do not get the "error message" directly which is displayed in the backend for now. DataHandler::errorLog[] is not checked and converted to test failures / exception or something similar, thus the database exception / error log entry got swallowed in TF ActionService methods(). Will discuss this and some other findings with lolli the next days, as we have some points to tightend the whole testing even more (thanks Oliver, would not have found these without your test request). Leaving this one testcase which basicly covers this with a error message if broken again, even if missleading for now. -
Benni Mack voted on patch set 4 V +1 CR +1 02/22/22, 08:01
-
Oli Bartsch commented on patch set 4 V +2 CR +2 02/22/22, 08:32
Could we somehow test this? -
Oli Bartsch merged patch set 5 02/22/22, 08:32
-
Oli Bartsch commented on patch set 5 02/22/22, 08:33
Reply
Done.