Review main Merged

73637[TASK] Streamline ext:install FileSessionHandler

Stefan Bürk CR +2 V +2 Normal +19 −49 updated 02/22/22, 08:31

Commit message

Streamline FileSessionHandler provided by ext:install
to use proper argument and return type hints, which
also matches the implemented SessionHandlerInterface.

This is hardcoded in the install tool, thus can be
safely adopted which makes phpstan a bit happier.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 915

  1. Stefan Bürk uploaded patch set 1 02/22/22, 03:14

  2. Stefan Bürk updated the commit message in patch set 2 02/22/22, 03:15

  3. core-ci voted on patch set 1 V -1 02/22/22, 03:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24023

  4. core-ci voted on patch set 2 V -1 02/22/22, 03:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24024

  5. Stefan Bürk uploaded patch set 3 02/22/22, 03:35

  6. Stefan Bürk updated the commit message in patch set 4 02/22/22, 03:36

  7. Stefan Bürk updated the commit message in patch set 5 02/22/22, 03:37

  8. core-ci voted on patch set 4 V +1 02/22/22, 03:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24026

  9. core-ci voted on patch set 3 V +1 02/22/22, 03:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24025

  10. core-ci voted on patch set 5 V +1 02/22/22, 03:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24027

  11. Stefan Bürk uploaded patch set 6 02/22/22, 03:51

  12. core-ci voted on patch set 6 V +1 02/22/22, 03:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24028

  13. Benjamin Franzke voted on patch set 6 V +1 CR +1 02/22/22, 07:18

  14. Benni Mack commented on patch set 6 V +2 CR +2 02/22/22, 08:31

    good one, I had something similar already done a few months ago but never pushed it, so I'm really happy you took care of that one!
  15. Benni Mack merged patch set 7 02/22/22, 08:31