Review main Merged Breaking

73638[!!!][TASK] Extract record access checks from TSFE

Benni Mack CR +2 V +2 Hard +561 −60 updated 02/24/22, 07:20

Commit message

Record access checks are moved from TSFE to the
new RecordAccessVoter class. This encapsulates
corresponding logic at a central place.

In addition, the existing hook
$GLOBALS[TYPO3_CONF_VARS][SC_OPTIONS][tslib/class.tslib_fe.php][hook_checkEnableFields]
is removed in favor of the new PSR-14 RecordAccessGrantedEvent.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1926

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 02/22/22, 09:10

  1. core-ci voted on patch set 1 V -1 02/22/22, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24035

  2. Benni Mack uploaded patch set 2 02/22/22, 11:55

  3. Benni Mack uploaded patch set 3 02/22/22, 12:06

  4. core-ci voted on patch set 2 V -1 02/22/22, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24043

  5. core-ci voted on patch set 3 V -1 02/22/22, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24044

  6. Oli Bartsch uploaded patch set 4 02/22/22, 15:53

  7. core-ci voted on patch set 4 V +1 02/22/22, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24046

  8. Oli Bartsch uploaded patch set 5 02/22/22, 19:59

  9. core-ci voted on patch set 5 V +1 02/22/22, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24062

  10. Benni Mack uploaded patch set 6 02/22/22, 20:28

  11. Benni Mack voted on patch set 6 V +1 CR +1 02/22/22, 20:34

  12. core-ci voted on patch set 6 V +1 02/22/22, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24063

  13. Stefan Bürk voted on patch set 6 CR +1 02/22/22, 20:46

  14. Stefan Bürk voted on patch set 6 V +1 02/22/22, 20:52

  15. Oli Bartsch voted on patch set 6 V +2 CR +2 02/22/22, 21:23

  16. Oli Bartsch voted on patch set 6 V 0 CR -1 02/22/22, 21:24

  17. Oli Bartsch uploaded patch set 7 02/22/22, 21:25

  18. core-ci voted on patch set 7 V +1 02/22/22, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24065

  19. Benni Mack voted on patch set 7 V +1 CR +1 02/22/22, 21:41

  20. Stefan Bürk voted on patch set 7 V +1 CR +1 02/23/22, 04:34

  21. Benni Mack voted on patch set 7 V +2 CR +2 02/23/22, 07:12

  22. Benni Mack merged patch set 8 02/23/22, 07:12

  23. Oliver Hader commented on patch set 8 02/23/22, 11:07

    RecordAccessVoter.php:96

    Should be evaluated later and default to false... → in case a table has `fe_group` defined and `$record[fe_groups]` is not empty, then a missing `frontend.user` MUST NOT grant access
  24. Oliver Hader commented on patch set 8 02/23/22, 11:07

    That would be a post -1 on reading from my side
  25. Benni Mack commented on patch set 8 02/24/22, 07:20

    RecordAccessVoter.php:96 Reply Unresolved