73638[!!!][TASK] Extract record access checks from TSFE
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/core/Classes/Domain/Access/RecordAccessGrantedEvent.phpnew+80 −0
- typo3/sysext/core/Classes/Domain/Access/RecordAccessVoter.php2new+123 −0
- typo3/sysext/core/Configuration/Services.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96996-HookCheckEnableFieldsRemoved.rstnew+37 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-96996-DeprecateTypoScriptFrontendController-checkEnableFields.rstnew+35 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96996-PSR-14EventForModifyingRecordAccessEvaluation.rstnew+64 −0
- typo3/sysext/core/Tests/Functional/Domain/Access/RecordAccessVoterTest.phpnew+189 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+4 −4
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+12 −55
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+2 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
Review log 1926
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 02/22/22, 09:10
-
core-ci voted on patch set 1 V -1 02/22/22, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24035
-
Benni Mack uploaded patch set 2 02/22/22, 11:55
-
Benni Mack uploaded patch set 3 02/22/22, 12:06
-
core-ci voted on patch set 2 V -1 02/22/22, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24043
-
core-ci voted on patch set 3 V -1 02/22/22, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24044
-
Oli Bartsch uploaded patch set 4 02/22/22, 15:53
-
core-ci voted on patch set 4 V +1 02/22/22, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24046
-
Oli Bartsch uploaded patch set 5 02/22/22, 19:59
-
core-ci voted on patch set 5 V +1 02/22/22, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24062
-
Benni Mack uploaded patch set 6 02/22/22, 20:28
-
Benni Mack voted on patch set 6 V +1 CR +1 02/22/22, 20:34
-
core-ci voted on patch set 6 V +1 02/22/22, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24063
-
Stefan Bürk voted on patch set 6 CR +1 02/22/22, 20:46
-
Stefan Bürk voted on patch set 6 V +1 02/22/22, 20:52
-
Oli Bartsch voted on patch set 6 V +2 CR +2 02/22/22, 21:23
-
Oli Bartsch voted on patch set 6 V 0 CR -1 02/22/22, 21:24
-
Oli Bartsch uploaded patch set 7 02/22/22, 21:25
-
core-ci voted on patch set 7 V +1 02/22/22, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24065
-
Benni Mack voted on patch set 7 V +1 CR +1 02/22/22, 21:41
-
Stefan Bürk voted on patch set 7 V +1 CR +1 02/23/22, 04:34
-
Benni Mack voted on patch set 7 V +2 CR +2 02/23/22, 07:12
-
Benni Mack merged patch set 8 02/23/22, 07:12
-
Oliver Hader commented on patch set 8 02/23/22, 11:07
-
Oliver Hader commented on patch set 8 02/23/22, 11:07
That would be a post -1 on reading from my side -
Benni Mack commented on patch set 8 02/24/22, 07:20
RecordAccessVoter.php:96Reply Unresolved
RecordAccessVoter.php:96