73644[!!!][TASK] Streamline Extbase validators
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 84
- Build/phpstan/phpstan-baseline.neon+0 −55
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96998-ExtbaseValidatorInterfaceChanged.rst2new+122 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+11 −26
- typo3/sysext/extbase/Classes/Mvc/Controller/Argument.php2+11 −11
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractCompositeValidator.php+15 −39
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractGenericObjectValidator.phpnew+172 −0
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractValidator.php+20 −45
- typo3/sysext/extbase/Classes/Validation/Validator/AlphanumericValidator.php+4 −4
- typo3/sysext/extbase/Classes/Validation/Validator/BooleanValidator.php+4 −4
- typo3/sysext/extbase/Classes/Validation/Validator/CollectionValidator.php+7 −19
- typo3/sysext/extbase/Classes/Validation/Validator/ConjunctionValidator.php+4 −3
- typo3/sysext/extbase/Classes/Validation/Validator/DateTimeValidator.php+4 −4
- typo3/sysext/extbase/Classes/Validation/Validator/DisjunctionValidator.php+4 −3
- typo3/sysext/extbase/Classes/Validation/Validator/EmailAddressValidator.php+5 −5
- typo3/sysext/extbase/Classes/Validation/Validator/FloatValidator.php+4 −2
- typo3/sysext/extbase/Classes/Validation/Validator/GenericObjectValidator.php+5 −182
- typo3/sysext/extbase/Classes/Validation/Validator/IntegerValidator.php+4 −4
- typo3/sysext/extbase/Classes/Validation/Validator/NotEmptyValidator.php+5 −5
- typo3/sysext/extbase/Classes/Validation/Validator/NumberRangeValidator.php+4 −4
- typo3/sysext/extbase/Classes/Validation/Validator/NumberValidator.php+4 −4
Show 64 more files
- typo3/sysext/extbase/Classes/Validation/Validator/ObjectValidatorInterface.php+3 −1
- typo3/sysext/extbase/Classes/Validation/Validator/RegularExpressionValidator.php+5 −4
- typo3/sysext/extbase/Classes/Validation/Validator/StringLengthValidator.php+5 −4
- typo3/sysext/extbase/Classes/Validation/Validator/StringValidator.php+4 −4
- typo3/sysext/extbase/Classes/Validation/Validator/TextValidator.php+2 −4
- typo3/sysext/extbase/Classes/Validation/Validator/UrlValidator.php+2 −4
- typo3/sysext/extbase/Classes/Validation/Validator/ValidatorInterface.php+8 −18
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+22 −45
- typo3/sysext/extbase/Configuration/Services.php+3 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Validator/PostValidator.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Validation/Validator/CustomNotInjectableValidator.phpdeleted+0 −38
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Validation/Validator/CustomValidator.php+2 −17
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Configuration/Services.yaml+0 −4
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_argument_test/Classes/Domain/Validation/Validator/FailingValidator.php+1 −4
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Validation/Validator/CustomValidator.php+1 −4
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+2 −3
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/AlphanumericValidatorTest.phpnew+71 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/BooleanValidatorTest.phpnew+119 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/CollectionValidatorTest.phpnew+162 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/ConjunctionValidatorTest.phprenamed+30 −16
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/DateTimeValidatorTest.phprenamed+21 −23
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/EmailAddressValidatorTest.phpnew+71 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/FloatValidatorTest.phprenamed+16 −12
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/IntegerValidatorTest.phprenamed+16 −9
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/NotEmptyValidatorTest.phprenamed+26 −14
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/NumberRangeValidatorTest.phprenamed+16 −22
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/NumberValidatorTest.phpnew+56 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/RegularExpressionValidatorTest.php+44 −5
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/StringLengthValidatorTest.phprenamed+41 −55
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/StringValidatorTest.phpnew+67 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/TextValidatorTest.phprenamed+15 −9
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/UrlValidatorTest.phprenamed+8 −20
- typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php+2 −15
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/Validation/Validator/DummyValidator.php+5 −8
- typo3/sysext/extbase/Tests/Unit/Validation/Fixtures/Validation/Validator/CustomValidator.php+1 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/Fixture/AbstractCompositeValidatorClass.php+2 −16
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/Fixture/AbstractValidatorClass.php+1 −7
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AbstractCompositeValidatorTest.php+8 −7
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AbstractValidatorTest.php+8 −7
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AlphanumericValidatorTest.phpdeleted+0 −75
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BooleanValidatorTest.phpdeleted+0 −131
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/CollectionValidatorTest.phpdeleted+0 −200
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/DisjunctionValidatorTest.php+8 −9
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/EmailAddressValidatorTest.phpdeleted+0 −75
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php+5 −8
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/NumberValidatorTest.phpdeleted+0 −64
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/RegularExpressionValidatorTest.phpdeleted+0 −119
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/StringValidatorTest.phpdeleted+0 −69
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+6 −18
- typo3/sysext/form/Classes/Mvc/Validation/CountValidator.php+2 −4
- typo3/sysext/form/Classes/Mvc/Validation/DateRangeValidator.php+5 −14
- typo3/sysext/form/Classes/Mvc/Validation/EmptyValidator.php+2 −4
- typo3/sysext/form/Classes/Mvc/Validation/FileSizeValidator.php+3 −3
- typo3/sysext/form/Classes/Mvc/Validation/MimeTypeValidator.php+4 −4
- typo3/sysext/form/Classes/Mvc/ProcessingRule.php+1 −0
- typo3/sysext/form/Tests/Functional/Mvc/Validation/CountValidatorTest.phprenamed+20 −36
- typo3/sysext/form/Tests/Functional/Mvc/Validation/DateRangeValidatorTest.phprenamed+28 −53
- typo3/sysext/form/Tests/Functional/Mvc/Validation/EmptyValidatorTest.phprenamed+24 −41
- typo3/sysext/form/Tests/Functional/Mvc/Validation/FileSizeValidatorTest.phprenamed+25 −46
- typo3/sysext/form/Tests/Functional/Mvc/Validation/MimeTypeValidatorTest.php+99 −15
- typo3/sysext/form/Tests/Unit/Mvc/Fixtures/TestValidator.phprenamed+2 −5
- typo3/sysext/form/Tests/Unit/Mvc/Property/PropertyMappingConfigurationTest.php+2 −1
- typo3/sysext/form/Tests/Unit/Mvc/Validation/MimeTypeValidatorTest.phpdeleted+0 −150
- typo3/sysext/form/Tests/Unit/Mvc/ProcessingRuleTest.php+12 −6
Review log 1624
-
Christian Kuhn uploaded patch set 1 02/22/22, 13:56
-
core-ci voted on patch set 1 V -1 02/22/22, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24045
-
Christian Kuhn uploaded patch set 2 02/22/22, 16:08
-
core-ci voted on patch set 2 V -1 02/22/22, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24049
-
Christian Kuhn uploaded patch set 3 02/22/22, 16:23
-
core-ci voted on patch set 3 V -1 02/22/22, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24051
-
Christian Kuhn uploaded patch set 4 02/22/22, 16:31
-
core-ci voted on patch set 4 V +1 02/22/22, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24052
-
Christian Kuhn uploaded patch set 5 02/22/22, 18:24
-
Christian Kuhn uploaded patch set 6 02/22/22, 18:26
-
Christian Kuhn uploaded patch set 7 02/22/22, 18:28
-
core-ci voted on patch set 5 V +1 02/22/22, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24055
-
core-ci voted on patch set 6 V +1 02/22/22, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24056
-
core-ci voted on patch set 7 V +1 02/22/22, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24057
-
Stefan Bürk voted on patch set 7 V +1 CR +1 02/22/22, 19:17
-
Benni Mack commented on patch set 7 CR +1 02/22/22, 20:39
-
Oli Bartsch commented on patch set 7 02/22/22, 21:36
Breaking-96998-ExtbaseValidatorInterfaceChanged.rst:38duplicate -
Benni Mack commented on patch set 8 02/22/22, 21:42
Published edit on patch set 7. -
Benni Mack voted on patch set 8 V +1 CR +1 02/22/22, 21:42
-
Benni Mack commented on patch set 8 02/22/22, 21:42
Breaking-96998-ExtbaseValidatorInterfaceChanged.rst:38ReplyDoneArgument.php:131ReplyDone -
core-ci voted on patch set 8 V +1 02/22/22, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24066
-
Stefan Bürk voted on patch set 8 V +1 CR +1 02/23/22, 04:34
-
Benni Mack voted on patch set 8 V +2 CR +2 02/23/22, 07:13
-
Benni Mack merged patch set 9 02/23/22, 07:13
Argument.php:131