Review main Merged Breaking

73644[!!!][TASK] Streamline Extbase validators

Christian Kuhn CR +2 V +2 Nightmare +1525 −1974 updated 02/23/22, 07:13

Commit message

This follows the preparations of #96332 which has
been applied to v11 and v12.

The Extbase validator interfaces are streamlined
and more strict, setOptions() is now mandatory.

All validators now declace strict_types=1 and
all non-abstract validators are declared final.

A ReST file of the breaking interface and
AbstractValidator signature changes explains
details on how to stay compatible with v11 & v12
aware extensions.

Since a lot of the existing unit tests mock
single validator subjects, which is no longer
possible when they're final, those tests are
transferred to functional tests.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 84

Show 64 more files

Review log 1624

  1. Christian Kuhn uploaded patch set 1 02/22/22, 13:56

  2. core-ci voted on patch set 1 V -1 02/22/22, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24045

  3. Christian Kuhn uploaded patch set 2 02/22/22, 16:08

  4. core-ci voted on patch set 2 V -1 02/22/22, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24049

  5. Christian Kuhn uploaded patch set 3 02/22/22, 16:23

  6. core-ci voted on patch set 3 V -1 02/22/22, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24051

  7. Christian Kuhn uploaded patch set 4 02/22/22, 16:31

  8. core-ci voted on patch set 4 V +1 02/22/22, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24052

  9. Christian Kuhn uploaded patch set 5 02/22/22, 18:24

  10. Christian Kuhn uploaded patch set 6 02/22/22, 18:26

  11. Christian Kuhn uploaded patch set 7 02/22/22, 18:28

  12. core-ci voted on patch set 5 V +1 02/22/22, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24055

  13. core-ci voted on patch set 6 V +1 02/22/22, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24056

  14. core-ci voted on patch set 7 V +1 02/22/22, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24057

  15. Stefan Bürk voted on patch set 7 V +1 CR +1 02/22/22, 19:17

  16. Benni Mack commented on patch set 7 CR +1 02/22/22, 20:39

    Argument.php:131

    space missing
  17. Oli Bartsch commented on patch set 7 02/22/22, 21:36

    Breaking-96998-ExtbaseValidatorInterfaceChanged.rst:38

    duplicate
  18. Benni Mack commented on patch set 8 02/22/22, 21:42

    Published edit on patch set 7.
  19. Benni Mack voted on patch set 8 V +1 CR +1 02/22/22, 21:42

  20. Benni Mack commented on patch set 8 02/22/22, 21:42

    Breaking-96998-ExtbaseValidatorInterfaceChanged.rst:38 Reply

    Done

    Argument.php:131 Reply

    Done
  21. core-ci voted on patch set 8 V +1 02/22/22, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24066

  22. Stefan Bürk voted on patch set 8 V +1 CR +1 02/23/22, 04:34

  23. Benni Mack voted on patch set 8 V +2 CR +2 02/23/22, 07:13

  24. Benni Mack merged patch set 9 02/23/22, 07:13