Review main Merged

73647[TASK] CI: Only retry acceptance tests on failures

Stefan Bürk CR +2 V +2 Normal +58 −2 updated 02/22/22, 18:57

Commit message

Acceptance tests are the most likely tests to recover
properly when automaticly retrying on test execution
failure. CGL, integration, unit and functional tests
on the other hand are more likely to fail with real
issues and retry won't fix these issues, thus wasting
CI execution time and job slots.

The patch changes the default retry back to zero
retries, except for 'acceptance' tests, including
'acceptanceInstall' tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 913

  1. Stefan Bürk uploaded patch set 1 02/22/22, 18:20

  2. Stefan Bürk updated the commit message in patch set 2 02/22/22, 18:21

  3. core-ci voted on patch set 2 V +1 02/22/22, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24054

  4. core-ci voted on patch set 1 V +1 02/22/22, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24053

  5. Stefan Bürk uploaded patch set 3 02/22/22, 18:38

  6. Stefan Bürk commented on patch set 2 02/22/22, 18:39

    Patchset #3 has broken tests and cgl, which is intended !
  7. Christian Kuhn uploaded patch set 4 02/22/22, 18:47

  8. core-ci voted on patch set 3 V -1 02/22/22, 18:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24058

  9. core-ci voted on patch set 4 V +1 02/22/22, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24059

  10. Christian Kuhn commented on patch set 4 V +1 CR +1 02/22/22, 18:55

    let's see if it works out ...
  11. Stefan Bürk voted on patch set 4 V +1 CR +1 02/22/22, 18:56

  12. Christian Kuhn commented on patch set 4 V +2 CR +2 02/22/22, 18:57

    will take the freedom to merge this.
  13. Christian Kuhn merged patch set 5 02/22/22, 18:57