Review main Merged

73649[TASK] Allow setting ContentLength response header in debug mode

Benni Mack CR +2 V +2 Easy +6 −6 updated 02/23/22, 11:07

Commit message

Since TYPO3 v11, the "debug" information
from config.debug = 1 is added at a HTTP Header
Level, and not as HTML comment, thus the additional
check to enable content length as HTTP header
does not need to respect this option anymore.

Additional checks might be removed as well at a later point.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 812

  1. Benni Mack uploaded patch set 1 02/22/22, 22:26

  2. core-ci voted on patch set 1 V +1 02/22/22, 22:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24069

  3. Stefan Bürk updated the commit message in patch set 2 02/23/22, 07:43

  4. core-ci voted on patch set 2 V +1 02/23/22, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24076

  5. Stefan Bürk updated the commit message in patch set 3 02/23/22, 08:03

  6. core-ci voted on patch set 3 V +1 02/23/22, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24077

  7. Benni Mack commented on patch set 4 02/23/22, 08:31

    Published edit on patch set 3.
  8. core-ci voted on patch set 4 V +1 02/23/22, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24082

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 02/23/22, 10:02

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 02/23/22, 11:02

  11. Benni Mack voted on patch set 4 V +2 CR +2 02/23/22, 11:07

  12. Benni Mack merged patch set 5 02/23/22, 11:07