Review main Merged

73650[BUGFIX] Fix callback module namespace in FileProvider

Oli Bartsch CR +2 V +2 Easy +4 −1 updated 02/23/22, 09:19

Commit message

With the JavaScript module namespace change to @typo3/, the
filelist context menu actions have been forgotten to be updated.
Also a the contextmenu importmap tag was missing in order
for the context menu to work in the file-navigation-tree.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 710

  1. Oli Bartsch uploaded patch set 1 02/22/22, 22:26

  2. Oli Bartsch updated the commit message in patch set 2 02/22/22, 22:28

  3. core-ci voted on patch set 1 V +1 02/22/22, 22:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24070

  4. core-ci voted on patch set 2 V +1 02/22/22, 22:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24071

  5. Benjamin Franzke uploaded patch set 3 02/23/22, 08:57

  6. core-ci voted on patch set 3 V +1 02/23/22, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24084

  7. Benjamin Franzke wrote 02/23/22, 09:06

    Topic set to esm
  8. Stefan Bürk voted on patch set 3 V +1 CR +1 02/23/22, 09:18

  9. Oli Bartsch voted on patch set 3 V +2 CR +2 02/23/22, 09:18

  10. Oli Bartsch merged patch set 4 02/23/22, 09:19