Review 11.5 Merged

73674[TASK] Raise typo3/cms-styleguide:"~11.5.4"

Stefan Bürk CR +2 V +2 Easy +11 −11 updated 02/24/22, 09:53

Commit message

This patch raises styleguide to the recently
released version to test against a more actual
codebase, including backports and the one or
other bugfix (postgres install etc).

used command:

> composer req typo3/cms-styleguide:"~11.5.4" --dev
> cd Build/composer ; \
    rm -rf composer.json ; \
    mv composer.dist.json composer.json ; \
    composer req typo3/cms-styleguide:"~11.5.4" \
      --dev --no-update ; \
    mv composer.json composer.dist.json ; \
    cd ../../

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1420

  1. Stefan Bürk uploaded patch set 1 02/23/22, 11:38

  2. core-ci voted on patch set 1 V +1 02/23/22, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24098

  3. Stefan Bürk commented on patch set 1 02/23/22, 11:48

  4. core-ci voted on patch set 1 V -1 02/23/22, 12:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24099

  5. Stefan Bürk abandoned the change 02/23/22, 12:14

    locked/max working as verification, min not - so using the dev constrain do not work out - but the main goal was to test current styleguide v11 branch if full tests are green, which was archieved.
  6. Stefan Bürk restored the change 02/23/22, 16:31

  7. Stefan Bürk uploaded patch set 2 02/23/22, 16:53

  8. Stefan Bürk updated the commit message in patch set 3 02/23/22, 16:53

  9. core-ci voted on patch set 2 V +1 02/23/22, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24130

  10. core-ci voted on patch set 3 V +1 02/23/22, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24131

  11. Stefan Bürk commented on patch set 3 02/23/22, 17:33

  12. core-ci commented on patch set 3 02/23/22, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24139

  13. Stefan Bürk commented on patch set 3 02/23/22, 18:00

    Nightly green.
  14. Oliver Klee voted on patch set 3 CR +1 02/23/22, 18:18

  15. Stefan Bürk updated the commit message in patch set 4 02/23/22, 18:39

  16. core-ci voted on patch set 4 V +1 02/23/22, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24143

  17. Christian Kuhn voted on patch set 4 V +1 CR +1 02/24/22, 09:31

  18. Oli Bartsch voted on patch set 4 V +1 CR +1 02/24/22, 09:52

  19. Christian Kuhn voted on patch set 4 V +2 CR +2 02/24/22, 09:53

  20. Christian Kuhn merged patch set 5 02/24/22, 09:53