Review main Merged

73677[TASK] Deprecate ContentObjectRenderer->getTreeList()

Benni Mack CR +2 V +2 Expert +482 −725 updated 03/02/22, 20:18

Commit message

The method getTreeList() has had a difficult time
to use, and its logic is now moved to

* PageRepository->getPageIdsRecursive()
* PageRepository->getDescendantPageIdsRecursive()

using a better API to understand and streamlined code.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 2646

Show 1121 earlier messages
  1. Benni Mack uploaded patch set 1 02/23/22, 13:46

  2. core-ci voted on patch set 1 V -1 02/23/22, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24105

  3. Benni Mack uploaded patch set 2 02/23/22, 14:12

  4. core-ci voted on patch set 2 V -1 02/23/22, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24108

  5. Benni Mack uploaded patch set 3 02/23/22, 16:35

  6. core-ci voted on patch set 3 V -1 02/23/22, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24126

  7. Benni Mack uploaded patch set 4 02/23/22, 21:04

  8. Benni Mack uploaded patch set 5 02/23/22, 21:15

  9. core-ci voted on patch set 4 V -1 02/23/22, 21:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24150

  10. core-ci voted on patch set 5 V -1 02/23/22, 21:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24151

  11. Benni Mack uploaded patch set 6 02/23/22, 21:41

  12. core-ci voted on patch set 6 V -1 02/23/22, 21:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24154

  13. Benni Mack uploaded patch set 7 02/24/22, 15:50

  14. core-ci voted on patch set 7 V -1 02/24/22, 16:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24202

  15. Benni Mack uploaded patch set 8 02/24/22, 16:19

  16. core-ci voted on patch set 8 V +1 02/24/22, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24204

  17. Benni Mack updated the commit message in patch set 9 02/24/22, 17:34

  18. core-ci voted on patch set 9 V +1 02/24/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24210

  19. Benni Mack uploaded patch set 10 02/24/22, 20:29

  20. Benni Mack uploaded patch set 11 02/24/22, 20:31

  21. core-ci voted on patch set 10 V -1 02/24/22, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24232

  1. core-ci voted on patch set 11 V +1 02/24/22, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24233

  2. Benni Mack uploaded patch set 12 03/02/22, 14:50

  3. core-ci voted on patch set 12 V -1 03/02/22, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24464

  4. Benni Mack uploaded patch set 13 03/02/22, 15:14

  5. core-ci voted on patch set 13 V -1 03/02/22, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24466

  6. Benni Mack uploaded patch set 14 03/02/22, 15:29

  7. core-ci voted on patch set 14 V +1 03/02/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24469

  8. Benni Mack uploaded patch set 15 03/02/22, 16:11

  9. core-ci voted on patch set 15 V -1 03/02/22, 16:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24471

  10. Benni Mack uploaded patch set 16 03/02/22, 16:24

  11. Benni Mack uploaded patch set 17 03/02/22, 16:33

  12. core-ci voted on patch set 16 V +1 03/02/22, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24473

  13. core-ci voted on patch set 17 V +1 03/02/22, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24474

  14. Oli Bartsch uploaded patch set 18 03/02/22, 17:25

  15. core-ci voted on patch set 18 V +1 03/02/22, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24475

  16. Benni Mack updated the commit message in patch set 19 03/02/22, 17:34

  17. Benni Mack updated the commit message in patch set 20 03/02/22, 17:35

  18. Oli Bartsch voted on patch set 20 V +1 CR +1 03/02/22, 17:36

  19. Stefan Bürk voted on patch set 20 CR -1 03/02/22, 17:37

  20. core-ci voted on patch set 19 V +1 03/02/22, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24476

  21. core-ci voted on patch set 20 V +1 03/02/22, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24477

  22. Stefan Bürk commented on patch set 20 V +1 CR +1 03/02/22, 18:41

    Looks good and is working. But isn't this technically also a "feature" because of the new API methods in PageRepository ? Not sure when "new" stuff is a FEATURE and when not, yet - so take may appolize for asking ;)
  23. Stefan Bürk commented on patch set 20 03/02/22, 19:58

    Reply

    Done
  24. Benni Mack commented on patch set 20 V +2 CR +2 03/02/22, 20:18

    Reply

    See e.g. here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73638 - New PHP methods aren't usually declared as feature. Sometimes it does make sense to define a new API as a feature, but in this case, this is very lowlevel. Features are something where users, editors, integrators or developers are welcome to use right away which wasn't possible before.
  25. Benni Mack merged patch set 21 03/02/22, 20:18