73677[TASK] Deprecate ContentObjectRenderer->getTreeList()
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 20
- Build/phpstan/phpstan-baseline.neon+0 −15
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+270 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-97027-ContentObjectRenderer-getTreeList.rstnew+51 −0
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php+68 −1
- typo3/sysext/core/Tests/Functional/Fixtures/pages.csv+24 −24
- typo3/sysext/extbase/Classes/Configuration/AbstractConfigurationManager.php+1 −10
- typo3/sysext/extbase/Classes/Configuration/FrontendConfigurationManager.php+9 −32
- typo3/sysext/extbase/Tests/Unit/Configuration/AbstractConfigurationManagerTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php+8 −124
- typo3/sysext/felogin/Classes/Controller/AbstractLoginFormController.php+3 −16
- typo3/sysext/felogin/Tests/Unit/Controller/AbstractLoginControllerTest.phpdeleted+0 −77
- typo3/sysext/felogin/Tests/Unit/Controller/SettingsDataProvider.phpdeleted+0 −83
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+7 −8
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+17 −245
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+2 −10
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+0 −44
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+7 −15
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/seo/Classes/XmlSitemap/PagesXmlSitemapDataProvider.php+4 −8
- typo3/sysext/seo/Classes/XmlSitemap/RecordsXmlSitemapDataProvider.php+2 −11
Review log 2646
Show 1121 earlier messages
-
Benni Mack uploaded patch set 1 02/23/22, 13:46
-
core-ci voted on patch set 1 V -1 02/23/22, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24105
-
Benni Mack uploaded patch set 2 02/23/22, 14:12
-
core-ci voted on patch set 2 V -1 02/23/22, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24108
-
Benni Mack uploaded patch set 3 02/23/22, 16:35
-
core-ci voted on patch set 3 V -1 02/23/22, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24126
-
Benni Mack uploaded patch set 4 02/23/22, 21:04
-
Benni Mack uploaded patch set 5 02/23/22, 21:15
-
core-ci voted on patch set 4 V -1 02/23/22, 21:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24150
-
core-ci voted on patch set 5 V -1 02/23/22, 21:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24151
-
Benni Mack uploaded patch set 6 02/23/22, 21:41
-
core-ci voted on patch set 6 V -1 02/23/22, 21:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24154
-
Benni Mack uploaded patch set 7 02/24/22, 15:50
-
core-ci voted on patch set 7 V -1 02/24/22, 16:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24202
-
Benni Mack uploaded patch set 8 02/24/22, 16:19
-
core-ci voted on patch set 8 V +1 02/24/22, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24204
-
Benni Mack updated the commit message in patch set 9 02/24/22, 17:34
-
core-ci voted on patch set 9 V +1 02/24/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24210
-
Benni Mack uploaded patch set 10 02/24/22, 20:29
-
Benni Mack uploaded patch set 11 02/24/22, 20:31
-
core-ci voted on patch set 10 V -1 02/24/22, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24232
-
core-ci voted on patch set 11 V +1 02/24/22, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24233
-
Benni Mack uploaded patch set 12 03/02/22, 14:50
-
core-ci voted on patch set 12 V -1 03/02/22, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24464
-
Benni Mack uploaded patch set 13 03/02/22, 15:14
-
core-ci voted on patch set 13 V -1 03/02/22, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24466
-
Benni Mack uploaded patch set 14 03/02/22, 15:29
-
core-ci voted on patch set 14 V +1 03/02/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24469
-
Benni Mack uploaded patch set 15 03/02/22, 16:11
-
core-ci voted on patch set 15 V -1 03/02/22, 16:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24471
-
Benni Mack uploaded patch set 16 03/02/22, 16:24
-
Benni Mack uploaded patch set 17 03/02/22, 16:33
-
core-ci voted on patch set 16 V +1 03/02/22, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24473
-
core-ci voted on patch set 17 V +1 03/02/22, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24474
-
Oli Bartsch uploaded patch set 18 03/02/22, 17:25
-
core-ci voted on patch set 18 V +1 03/02/22, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24475
-
Benni Mack updated the commit message in patch set 19 03/02/22, 17:34
-
Benni Mack updated the commit message in patch set 20 03/02/22, 17:35
-
Oli Bartsch voted on patch set 20 V +1 CR +1 03/02/22, 17:36
-
Stefan Bürk voted on patch set 20 CR -1 03/02/22, 17:37
-
core-ci voted on patch set 19 V +1 03/02/22, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24476
-
core-ci voted on patch set 20 V +1 03/02/22, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24477
-
Stefan Bürk commented on patch set 20 V +1 CR +1 03/02/22, 18:41
Looks good and is working. But isn't this technically also a "feature" because of the new API methods in PageRepository ? Not sure when "new" stuff is a FEATURE and when not, yet - so take may appolize for asking ;) -
Stefan Bürk commented on patch set 20 03/02/22, 19:58
Reply
Done -
Benni Mack commented on patch set 20 V +2 CR +2 03/02/22, 20:18
Reply
See e.g. here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73638 - New PHP methods aren't usually declared as feature. Sometimes it does make sense to define a new API as a feature, but in this case, this is very lowlevel. Features are something where users, editors, integrators or developers are welcome to use right away which wasn't possible before. -
Benni Mack merged patch set 21 03/02/22, 20:18