73678[TASK] Streamline handling of TypoScript form overrides
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Björn Jacob +1
-
Verified V +2 Done
- waldhacker +2
- Björn Jacob +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+0 −28
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php3+32 −4
- typo3/sysext/form/Tests/Unit/Controller/FormFrontendControllerTest.php+0 −130
- typo3/sysext/form/Tests/Unit/Mvc/Persistence/FormPersistenceManagerTest.php+135 −0
Review log 1722
-
Elias Häußler uploaded patch set 1 02/23/22, 14:34
-
Elias Häußler updated the commit message in patch set 2 02/23/22, 14:35
-
Elias Häußler marked it work in progress 02/23/22, 14:36
-
Elias Häußler marked it ready for review 02/23/22, 14:43
-
core-ci voted on patch set 1 V -1 02/23/22, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24109
-
core-ci voted on patch set 2 V -1 02/23/22, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24110
-
Elias Häußler uploaded patch set 3 02/23/22, 14:54
-
Elias Häußler wrote 02/23/22, 14:55
Topic set to form -
core-ci voted on patch set 3 V +1 02/23/22, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24112
-
Oliver Hader commented on patch set 3 CR -1 02/23/22, 16:27
Not sure, whether this shall be back-ported to 11.5... might be okay... However, I'd like to see applying frontend TypoScript more explicitly (see my comment).FormPersistenceManager.php:91This method is invoked in frontend AND backend - I'm not sure whether it good/okay to overload things via TypoScript in that scope. In case the code shall be located here, I could imagine to make that more explicit, using a new signature, e.g. `load(string $persistenceIdentifier, int $flags = 0): array` and then ``` if ($flags & self::PROCESS_TYPOSCRIPT_SETTINGS) { $typoScript = $this->configurationManager->getConfiguration(...); $yaml = $this->overrideByTypoScriptSettings($yaml); } ``` -
waldhacker commented on patch set 3 02/23/22, 16:52
Reply
I think this should not be back-portet to 11.5. And I think that's more of a TASK than a BUGFIX... -
Elias Häußler commented on patch set 3 02/24/22, 10:50
FormPersistenceManager.php:91Reply> This method is invoked in frontend AND backend - I'm not sure whether it good/okay to overload things via TypoScript in that scope. You're right, and I already tested this in both frontend AND backend (form editor and form manager) scope. In backend, no `formDefinitionOverrides` are available per default, since the appropriate `BackendConfigurationManager` is used. `plugin.tx_form` is therefore not available, only `module.tx_form`. -
Elias Häußler updated the commit message in patch set 4 02/24/22, 10:51
-
Elias Häußler commented on patch set 4 02/24/22, 10:52
Reply
ack, changed it to TASK and removed backport to 11.5 -
core-ci voted on patch set 4 V +1 02/24/22, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24179
-
Björn Jacob commented on patch set 5 04/27/22, 08:38
Published edit on patch set 4. -
Björn Jacob commented on patch set 5 CR +1 04/27/22, 08:40
FormPersistenceManager.php:91ReplyDone -
core-ci voted on patch set 5 V +1 04/27/22, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26495
-
Björn Jacob commented on patch set 5 V +1 04/27/22, 09:36
Works like a charm. -
waldhacker voted on patch set 5 V +1 CR +1 04/27/22, 11:57
-
waldhacker voted on patch set 5 V +2 CR +2 04/27/22, 13:32
-
waldhacker merged patch set 6 04/27/22, 13:32