73679[TASK] Allow extension scanner reporting for dirs outside typo3conf
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Simon Gilli +1
- Jan Helke +1
-
Verified V +2 Done
- Benni Mack +2
- Simon Gilli +1
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2429
Show 34 earlier messages
-
Kevin Appelt uploaded patch set 1 02/23/22, 14:45
-
Kevin Appelt marked it work in progress 02/23/22, 14:45
-
core-ci voted on patch set 1 V -1 02/23/22, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24111
-
Kevin Appelt uploaded patch set 2 02/23/22, 14:58
-
Mathias Brodala commented on patch set 2 02/23/22, 15:03
-
Kevin Appelt marked it ready for review 02/23/22, 15:05
-
core-ci voted on patch set 2 V +1 02/23/22, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24113
-
Kevin Appelt uploaded patch set 3 02/23/22, 15:11
-
Kevin Appelt commented on patch set 3 02/23/22, 15:11
UpgradeController.php:203ReplyDone -
Mathias Brodala commented on patch set 3 CR +1 02/23/22, 15:11
UpgradeController.php:203ReplyDone -
core-ci voted on patch set 3 V +1 02/23/22, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24115
-
Stefan Bürk commented on patch set 3 02/23/22, 15:52
UpgradeController.php:199I think non extension packages should be skipped, too. But maybe I'm wrong (not sure about that meta data - maybe Helmut or Simon can say here more about it).UpgradeController.php:633Same as above - think we should skip non extension packages. Do not make sense to use the scanner against any general composer packages. Or ? -
Kevin Appelt commented on patch set 3 02/23/22, 16:08
UpgradeController.php:199ReplyGood point. I had !$package->getPackageMetaData()->isExtensionType() first, but this also matches the framework type. I guess (!$package->getPackageMetaData()->isExtensionType() || $package->getPackageMetaData()->isFrameworkType()) should do the job better. I will add another patchset.UpgradeController.php:633ReplyGood point. I had !$package->getPackageMetaData()->isExtensionType() first, but this also matches the framework type. I guess (!$package->getPackageMetaData()->isExtensionType() || $package->getPackageMetaData()->isFrameworkType()) should do the job better. I will add another patchset. -
Kevin Appelt uploaded patch set 4 02/23/22, 16:12
-
core-ci voted on patch set 4 V +1 02/23/22, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24125
-
Kevin Appelt commented on patch set 4 02/23/22, 19:38
This might help reviewing this change: https://forge.typo3.org/issues/97008#note-5 -
Simon Gilli commented on patch set 4 02/23/22, 19:59
Thanks! Some minor stuff and questions...UpgradeController.php:196I'd prefer `hasExtensions` hereExtensionScanner.html:73I don't get why you remove the .filename here. Was this a bug? -
Kevin Appelt uploaded patch set 5 02/23/22, 20:38
-
Kevin Appelt commented on patch set 5 02/23/22, 20:46
UpgradeController.php:196ReplyDoneExtensionScanner.html:73Reply{extensionScannerExtensionList} previously contained the data from the Finder and {extensionInTypo3conf} was in each case an object in which .filename contained for example 'styleguide'. By using the packageManager {extensionScannerExtensionList} now only contains an array of packages, so {extension} is already 'styleguide' without any other properties. -
core-ci voted on patch set 5 V +1 02/23/22, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24148
-
Jan Helke voted on patch set 5 CR +1 02/23/22, 21:01
-
Simon Gilli commented on patch set 5 02/24/22, 14:04
ExtensionScanner.html:73ReplyThanks, got it now. -
Kevin Appelt commented on patch set 5 02/25/22, 09:43
UpgradeController.php:199ReplyThe code is adjusted accordingly.UpgradeController.php:633ReplyThe code is adjusted accordingly. -
Helmut Hummel commented on patch set 5 02/28/22, 22:01
UpgradeController.php:199ReplyIt is an excellent question. For now, I would leave it like that, especially because the root package is also recognized as package which requires some extra thoughts. In the long run, though, anything that can extend TYPO3 API should be considered being an extension. -
Helmut Hummel commented on patch set 5 V +1 02/28/22, 22:12
Very nice cleanup! Thanks a lot!UpgradeController.php:639Does this actually do anything useful? -
Simon Gilli commented on patch set 5 V +1 CR +1 02/28/22, 22:13
Thanks! -
Kevin Appelt commented on patch set 5 03/01/22, 06:05
.UpgradeController.php:639ReplyThe original code contained ->sortByName() and I wanted to make sure that also the packages from the Package Manager are sorted alphabetically in any case. -
Benni Mack commented on patch set 5 V +2 CR +2 03/01/22, 07:42
UpgradeController.php:639ReplyDone -
Benni Mack merged patch set 6 03/01/22, 07:42
UpgradeController.php:203