73680[BUGFIX] Use per-language runtime cache for LanguageService
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Jan Delius +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Jan Delius +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1216
-
Jan Delius uploaded patch set 1 02/23/22, 15:43
-
Jan Delius commented on patch set 1 02/23/22, 15:46
To test the patch, you can create a middleware in the frontend, which simply outputs the translation of the "Notes" TCA tab according to the following code. Before the change, the translation of the language "de" came in the JSON in both cases. After the patch, both instances return the correct translation. $language = GeneralUtility::getContainer()->get(LanguageServiceFactory::class)->create('de'); $data1 = $language->sL('LLL:EXT:core/Resources/Private/Language/Form/locallang_tabs.xlf:notes'); $language2 = GeneralUtility::getContainer()->get(LanguageServiceFactory::class)->create('default'); $data2 = $language2->sL('LLL:EXT:core/Resources/Private/Language/Form/locallang_tabs.xlf:notes'); return new JsonResponse([$data1, $data2]); -
core-ci voted on patch set 1 V +1 02/23/22, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24120
-
Rico Drexler voted on patch set 1 V +1 CR +1 02/23/22, 16:14
-
Stefan Bürk commented on patch set 1 CR -1 02/23/22, 18:53
on it -
Stefan Bürk uploaded patch set 2 02/23/22, 20:04
-
Stefan Bürk commented on patch set 2 V +1 CR +1 02/23/22, 20:05
Changes: * added tests to cover this * added related issue to commit (and issue) * adjusted commit message -
Stefan Bürk updated the commit message in patch set 3 02/23/22, 20:07
-
core-ci voted on patch set 2 V +1 02/23/22, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24144
-
Jan Delius updated the commit message in patch set 4 02/23/22, 20:19
-
core-ci voted on patch set 3 V +1 02/23/22, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24145
-
core-ci voted on patch set 4 V +1 02/23/22, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24146
-
Stefan Bürk voted on patch set 4 V +1 CR +1 02/23/22, 20:33
-
Jan Delius voted on patch set 4 V +1 CR +1 02/23/22, 20:39
-
Benjamin Franzke voted on patch set 4 V +2 CR +2 02/23/22, 20:43
-
Benjamin Franzke merged patch set 5 02/23/22, 20:44