Review main Merged

73681[BUGFIX] Set options for MimeTypeValidator

Oli Bartsch CR +2 V +2 Easy +2 −1 updated 02/23/22, 16:51

Commit message

Since #96998, options have to be set using setOptions().

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 912

  1. Oli Bartsch uploaded patch set 1 02/23/22, 15:44

  2. Stefan Bürk updated the commit message in patch set 2 02/23/22, 15:53

  3. core-ci voted on patch set 1 V -1 02/23/22, 15:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24121

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 02/23/22, 15:55

  5. Stefan Bürk wrote 02/23/22, 15:55

    Removed Code-Review+1 by Stefan Bürk <stefan@buerk.tech>
  6. Stefan Bürk wrote 02/23/22, 15:55

    Removed Verified+1 by Stefan Bürk <stefan@buerk.tech>
  7. core-ci voted on patch set 1 V +1 02/23/22, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24121

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 02/23/22, 16:01

  9. core-ci voted on patch set 2 V +1 02/23/22, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24124

  10. Christian Kuhn commented on patch set 2 V +1 CR +1 02/23/22, 16:37

    hmpf ... various places don't use the factory method. i completely missed this place.
  11. Oli Bartsch voted on patch set 2 V +2 CR +2 02/23/22, 16:51

  12. Oli Bartsch merged patch set 3 02/23/22, 16:51