73682[BUGFIX] Add missing comma to array_merge() in WorkspaceService
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Klee +1
- Stefan Bürk +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1320
-
TYPO3com uploaded patch set 1 02/23/22, 16:38
-
core-ci voted on patch set 1 V +1 02/23/22, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24128
-
Stefan Bürk updated the commit message in patch set 2 02/23/22, 17:14
-
Stefan Bürk updated the commit message in patch set 3 02/23/22, 17:14
-
Stefan Bürk updated the commit message in patch set 4 02/23/22, 17:15
-
core-ci voted on patch set 2 V +1 02/23/22, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24135
-
core-ci voted on patch set 4 V +1 02/23/22, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24137
-
core-ci voted on patch set 3 V +1 02/23/22, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24136
-
Stefan Bürk updated the commit message in patch set 5 02/23/22, 17:48
-
Stefan Bürk updated the commit message in patch set 6 02/23/22, 17:49
-
core-ci voted on patch set 5 V +1 02/23/22, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24141
-
core-ci voted on patch set 6 V +1 02/23/22, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24142
-
Oliver Klee voted on patch set 6 CR +1 02/23/22, 18:18
-
Oli Bartsch voted on patch set 6 V +1 CR +1 02/23/22, 21:19
-
Stefan Bürk voted on patch set 6 V +1 CR +1 02/23/22, 21:48
-
Oliver Hader voted on patch set 6 CR +1 02/24/22, 08:34
-
Oliver Hader commented on patch set 6 02/24/22, 08:34
I'm wondering why no test-case failed... -
Oliver Hader commented on patch set 6 02/24/22, 08:45
Reply
.. ok, because we don't set `$GLOBALS['BE_USER']->uc['pageTree_temporaryMountPoint']` for the test actor -
Benni Mack voted on patch set 6 V +2 CR +2 02/24/22, 09:07
-
Benni Mack merged patch set 7 02/24/22, 09:07