73683[FEATURE] Skip translation of overridden form finisher options
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Björn Jacob +1
-
Verified V +2 Done
- waldhacker +2
- Björn Jacob +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/12.0/ Feature-90919-SkipTranslationOfOverriddenFormFinisherOptions.rst7new+55 −0
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Converters/FinisherOptionsFlexFormOverridesConverter.php2+25 −1
- typo3/sysext/form/Classes/Service/TranslationService.php+4 −0
- typo3/sysext/form/Tests/Unit/Controller/FormFrontendControllerTest.php+13 −0
- typo3/sysext/form/Tests/Unit/Service/TranslationServiceTest.php+19 −0
Review log 3146
Show 1521 earlier messages
-
Elias Häußler uploaded patch set 1 02/23/22, 16:50
-
core-ci voted on patch set 1 V -1 02/23/22, 17:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24129
-
Elias Häußler uploaded patch set 2 02/23/22, 17:10
-
core-ci voted on patch set 2 V +1 02/23/22, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24134
-
Elias Häußler updated the commit message in patch set 3 02/23/22, 17:20
-
core-ci voted on patch set 3 V +1 02/23/22, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24138
-
Tobias Jungmann voted on patch set 3 CR +1 04/27/22, 09:20
-
Björn Jacob commented on patch set 3 CR -1 04/27/22, 10:04
I think, this should be main only and a feature. I can provide a feature.rst- -
waldhacker commented on patch set 3 04/27/22, 13:45
Reply
Yes please -
waldhacker updated the commit message in patch set 4 04/27/22, 13:45
-
core-ci voted on patch set 4 V +1 04/27/22, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26510
-
Björn Jacob updated the commit message in patch set 5 04/27/22, 14:17
-
Oliver Klee commented on patch set 5 04/27/22, 14:27
FinisherOptionsFlexFormOverridesConverter.php:103I propose adding a PHPDoc type annotation for the array so readers and static code analysis can know more about what the method requires. -
core-ci voted on patch set 5 V +1 04/27/22, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26512
-
Björn Jacob uploaded patch set 6 04/27/22, 14:57
-
waldhacker commented on patch set 6 04/27/22, 15:07
Feature-90919-SkipTranslationOfOverriddenFormFinisherOptions.rst:16@bjoern.jacob Can you please mention that this option is automatically generated by the ext:form code (when ext:form recognizes a flexform override) and is documented here just for completeness? Of course, it can also be written manually into a form definition if required. -
core-ci voted on patch set 6 V -1 04/27/22, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26514
-
waldhacker updated the commit message in patch set 7 04/27/22, 15:39
-
Björn Jacob uploaded patch set 8 04/27/22, 15:45
-
Björn Jacob commented on patch set 8 04/27/22, 15:46
Reply
DoneFeature-90919-SkipTranslationOfOverriddenFormFinisherOptions.rst:16ReplyDone -
Björn Jacob uploaded patch set 9 04/27/22, 15:47
-
waldhacker voted on patch set 9 V +1 04/27/22, 15:54
-
core-ci voted on patch set 8 V -1 04/27/22, 15:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26525
-
core-ci voted on patch set 9 V -1 04/27/22, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26526
-
core-ci voted on patch set 7 V -1 04/27/22, 16:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26524
-
core-ci commented on patch set 9 04/27/22, 16:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26526
-
Björn Jacob commented on patch set 10 04/28/22, 06:13
Published edit on patch set 9. -
Björn Jacob voted on patch set 10 V +1 CR +1 04/28/22, 06:13
-
core-ci voted on patch set 10 V +1 04/28/22, 06:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26547
-
Oli Bartsch commented on patch set 10 04/28/22, 07:00
Feature-90919-SkipTranslationOfOverriddenFormFinisherOptions.rst:55As mentioned in Slack, the extension scanner tag is not required, but a "component" tag ist. So this should be something like: ".. index:: Frontend, Backend, ext:form" -
Björn Jacob commented on patch set 11 04/28/22, 08:03
Published edit on patch set 10. -
core-ci voted on patch set 11 V -1 04/28/22, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26554
-
Björn Jacob commented on patch set 12 04/28/22, 08:20
Published edit on patch set 11. -
Elias Häußler uploaded patch set 13 04/28/22, 08:26
-
Elias Häußler uploaded patch set 14 04/28/22, 08:29
-
Elias Häußler commented on patch set 14 04/28/22, 08:29
FinisherOptionsFlexFormOverridesConverter.php:103ReplyDone -
Björn Jacob voted on patch set 14 V +1 CR +1 04/28/22, 08:30
-
core-ci voted on patch set 14 V +1 04/28/22, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26560
-
core-ci voted on patch set 12 V -1 04/28/22, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26557
-
core-ci voted on patch set 13 V +1 04/28/22, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26559
-
waldhacker voted on patch set 14 V +2 CR +2 04/28/22, 09:10
-
waldhacker commented on patch set 14 04/28/22, 09:11
Feature-90919-SkipTranslationOfOverriddenFormFinisherOptions.rst:55ReplyDone -
waldhacker merged patch set 15 04/28/22, 09:11
-
Oli Bartsch commented on patch set 15 04/28/22, 09:59
Feature-90919-SkipTranslationOfOverriddenFormFinisherOptions.rst:55ReplyActually, "NotScanned" is superfluous in this context and should have been removed. -
waldhacker commented on patch set 15 04/28/22, 10:01
Feature-90919-SkipTranslationOfOverriddenFormFinisherOptions.rst:55ReplyOh, sorry. @bjoern.jacob can you please make another patch which removes this? -
Elias Häußler commented on patch set 15 04/28/22, 10:47
Feature-90919-SkipTranslationOfOverriddenFormFinisherOptions.rst:55Reply