Review main Abandoned Breaking

73684[!!!][TASK] Streamline UI of date range validator in form editor

Björn Jacob CR 0 V 0 Normal +90 −10 updated 02/24/22, 09:50

Commit message

The form framework ships a "date range validator". The validator
can for example be added via the form editor to the "date" form
element. The order of the available fields is not in line with all
of the other form elements. The field "Custom error message"
(validationErrorMessage) is always the last field. To further
streamline the UI, the order has been changed for this validator.

Since the order can only be adjusted by changing the key within
the form configuration, this patch is considered as breaking.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 34

  1. Björn Jacob uploaded patch set 1 02/23/22, 17:43

  2. core-ci voted on patch set 1 V +1 02/23/22, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24140

  3. Björn Jacob abandoned the change 02/24/22, 08:37

  4. Björn Jacob commented on patch set 1 02/24/22, 09:50

    We decided to abandon this patch. Instead we want to deprecate the order since configuration keys change. I have created a new ticket and pushed a new patch.