Review 11.5 Merged

73685[BUGFIX] Use per-language runtime cache for LanguageService

Benjamin Franzke CR +2 V +2 Normal +54 −1 updated 02/23/22, 21:02

Commit message

LanguageService state has been moved into runtime cache
for further reducing the need to keep the LanguageService
in a global state. Failing to predict the need to translate
into multiple languages in the same context and process,
$cacheIdentifier had not be included the language.

This patch adds the current language to the $cacheIndentifier
to support multiple language translation while keeping the
LanguageService state clean.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Benjamin Franzke uploaded patch set 1 02/23/22, 20:44

  2. core-ci voted on patch set 1 V +1 02/23/22, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24149

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 02/23/22, 21:01

  4. Benjamin Franzke merged patch set 2 02/23/22, 21:02