Review main Merged

73686[BUGFIX] Make RecordAccessVoter more strict

Benni Mack CR +2 V +2 Easy +4 −3 updated 02/24/22, 08:46

Commit message

This change adds a separate check that if no frontend.user
aspect is set, then the method "groupAccessGranted"
should default to false.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 02/23/22, 21:28

  2. Benni Mack updated the commit message in patch set 2 02/23/22, 21:28

  3. core-ci voted on patch set 1 V +1 02/23/22, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24152

  4. core-ci voted on patch set 2 V +1 02/23/22, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24153

  5. Oliver Hader voted on patch set 2 CR +1 02/24/22, 08:32

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 02/24/22, 08:45

  7. Oliver Hader voted on patch set 2 V +2 CR +2 02/24/22, 08:46

  8. Oliver Hader merged patch set 3 02/24/22, 08:46