Review main Merged

73687[FEATURE] Introduce TCA type "email"

Andreas Kienast CR +2 V +2 Hard +595 −83 updated 03/04/22, 08:01

Commit message

In our process of using dedicated TCA types,
the new TCA type "email" is introduced and
replaces "eval=email" of TCA type "input".

Notable changes to the previous "email" behaviour:
- "trim" is always be done in DataHandler and FormEngine
- The maxlength is set to 255, since this is the maximum
  length of an email address

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 3249

Show 1524 earlier messages
  1. Andreas Kienast uploaded patch set 1 02/23/22, 21:45

  2. core-ci voted on patch set 1 V -1 02/23/22, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24155

  3. Benni Mack uploaded patch set 2 02/24/22, 07:53

  4. Benni Mack uploaded patch set 3 02/24/22, 07:57

  5. Benni Mack commented on patch set 3 02/24/22, 07:58

    BackendUtility.php:1686

    should fixed_lg_cs like in "default"
  6. core-ci voted on patch set 2 V -1 02/24/22, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24161

  7. core-ci voted on patch set 3 V -1 02/24/22, 08:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24162

  8. Andreas Kienast uploaded patch set 4 02/27/22, 14:18

  9. core-ci voted on patch set 4 V -1 02/27/22, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24369

  10. Benni Mack updated the commit message in patch set 5 02/28/22, 10:37

  11. core-ci voted on patch set 5 V -1 02/28/22, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24383

  12. Benni Mack uploaded patch set 6 02/28/22, 10:51

  13. core-ci voted on patch set 6 V -1 02/28/22, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24384

  14. Benni Mack commented on patch set 6 02/28/22, 12:33

    BackendUtility.php:1686 Reply

    Done
  15. Georg Ringer commented on patch set 6 02/28/22, 17:38

    do we really duplicate so much in EmailElement?
  16. Benni Mack uploaded patch set 7 03/01/22, 07:52

  17. Benni Mack commented on patch set 6 03/01/22, 07:54

    Reply

    I strongly agree, however we do have quite some places where we should unify this (InputLink or InputColorPicker use a similar base), but as a separate step, if that's OK? I think once we sorted out the other types (see epic in forge), we can cleanly find the parts that are used everywhere
  18. core-ci voted on patch set 7 V +1 03/01/22, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24403

  19. Benni Mack uploaded patch set 8 03/01/22, 11:22

  20. core-ci voted on patch set 8 V -1 03/01/22, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24408

  21. Benni Mack uploaded patch set 9 03/03/22, 10:41

  22. Benni Mack uploaded patch set 10 03/03/22, 10:56

  23. core-ci voted on patch set 10 V -1 03/03/22, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24503

  24. Benni Mack uploaded patch set 11 03/03/22, 12:20

  1. core-ci voted on patch set 11 V -1 03/03/22, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24506

  2. Oli Bartsch commented on patch set 11 CR -1 03/03/22, 12:51

    On it
  3. Oli Bartsch uploaded patch set 12 03/03/22, 16:23

  4. Oli Bartsch uploaded patch set 13 03/03/22, 16:24

  5. core-ci voted on patch set 12 V -1 03/03/22, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24523

  6. core-ci voted on patch set 13 V -1 03/03/22, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24524

  7. Oli Bartsch uploaded patch set 14 03/03/22, 18:09

  8. core-ci voted on patch set 14 V +1 03/03/22, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24527

  9. Benni Mack commented on patch set 14 03/03/22, 20:48

    pages.php:676

    should we remove the "size" here?
  10. Oli Bartsch uploaded patch set 15 03/03/22, 21:11

  11. Oli Bartsch commented on patch set 15 03/03/22, 21:13

    pages.php:676 Reply

    As discussed, I would like to keep it here, since this otherwise differs to the "author" field which is in the same row.
  12. core-ci voted on patch set 15 V +1 03/03/22, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24529

  13. Oli Bartsch updated the commit message in patch set 16 03/03/22, 21:20

  14. core-ci voted on patch set 16 V +1 03/03/22, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24530

  15. Benni Mack uploaded patch set 17 03/03/22, 21:48

  16. Benni Mack voted on patch set 17 V +1 CR +1 03/03/22, 21:48

  17. Oli Bartsch voted on patch set 17 V +1 CR +1 03/03/22, 21:55

  18. core-ci voted on patch set 17 V +1 03/03/22, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24531

  19. Andreas Kienast commented on patch set 17 CR -1 03/04/22, 07:24

    on it
  20. Andreas Kienast uploaded patch set 18 03/04/22, 07:25

  21. Andreas Kienast voted on patch set 18 V +1 CR +1 03/04/22, 07:25

  22. Benni Mack voted on patch set 18 V +1 CR +1 03/04/22, 07:33

  23. core-ci voted on patch set 18 V +1 03/04/22, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24539

  24. Andreas Kienast voted on patch set 18 V +2 CR +2 03/04/22, 08:00

  25. Andreas Kienast merged patch set 19 03/04/22, 08:01