73687[FEATURE] Introduce TCA type "email"
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 23
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+3 −0
- typo3/sysext/backend/Classes/Form/Element/EmailElement.phpnew+232 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsProcessPlaceholders.php+8 −5
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+8 −5
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+18 −0
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+1 −0
- typo3/sysext/backend/Classes/Form/NodeFactory.php+1 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+2 −0
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+9 −0
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+93 −59
- typo3/sysext/core/Classes/DataHandling/TableColumnType.php+1 −0
- typo3/sysext/core/Classes/Migrations/TcaMigration.php+47 −1
- typo3/sysext/core/Classes/Resource/Search/QueryRestrictions/SearchTermRestriction.php+1 −0
- typo3/sysext/core/Configuration/TCA/be_users.php+1 −4
- typo3/sysext/core/Configuration/TCA/pages.php2+1 −4
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97013-NewTCATypeEmail.rstnew+85 −0
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+76 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+1 −0
- typo3/sysext/frontend/Configuration/TCA/fe_users.php+1 −3
Review log 3249
Show 1524 earlier messages
-
Andreas Kienast uploaded patch set 1 02/23/22, 21:45
-
core-ci voted on patch set 1 V -1 02/23/22, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24155
-
Benni Mack uploaded patch set 2 02/24/22, 07:53
-
Benni Mack uploaded patch set 3 02/24/22, 07:57
-
Benni Mack commented on patch set 3 02/24/22, 07:58
-
core-ci voted on patch set 2 V -1 02/24/22, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24161
-
core-ci voted on patch set 3 V -1 02/24/22, 08:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24162
-
Andreas Kienast uploaded patch set 4 02/27/22, 14:18
-
core-ci voted on patch set 4 V -1 02/27/22, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24369
-
Benni Mack updated the commit message in patch set 5 02/28/22, 10:37
-
core-ci voted on patch set 5 V -1 02/28/22, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24383
-
Benni Mack uploaded patch set 6 02/28/22, 10:51
-
core-ci voted on patch set 6 V -1 02/28/22, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24384
-
Benni Mack commented on patch set 6 02/28/22, 12:33
BackendUtility.php:1686ReplyDone -
Georg Ringer commented on patch set 6 02/28/22, 17:38
do we really duplicate so much in EmailElement? -
Benni Mack uploaded patch set 7 03/01/22, 07:52
-
Benni Mack commented on patch set 6 03/01/22, 07:54
Reply
I strongly agree, however we do have quite some places where we should unify this (InputLink or InputColorPicker use a similar base), but as a separate step, if that's OK? I think once we sorted out the other types (see epic in forge), we can cleanly find the parts that are used everywhere -
core-ci voted on patch set 7 V +1 03/01/22, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24403
-
Benni Mack uploaded patch set 8 03/01/22, 11:22
-
core-ci voted on patch set 8 V -1 03/01/22, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24408
-
Benni Mack uploaded patch set 9 03/03/22, 10:41
-
Benni Mack uploaded patch set 10 03/03/22, 10:56
-
core-ci voted on patch set 10 V -1 03/03/22, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24503
-
Benni Mack uploaded patch set 11 03/03/22, 12:20
-
core-ci voted on patch set 11 V -1 03/03/22, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24506
-
Oli Bartsch commented on patch set 11 CR -1 03/03/22, 12:51
On it -
Oli Bartsch uploaded patch set 12 03/03/22, 16:23
-
Oli Bartsch uploaded patch set 13 03/03/22, 16:24
-
core-ci voted on patch set 12 V -1 03/03/22, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24523
-
core-ci voted on patch set 13 V -1 03/03/22, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24524
-
Oli Bartsch uploaded patch set 14 03/03/22, 18:09
-
core-ci voted on patch set 14 V +1 03/03/22, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24527
-
Benni Mack commented on patch set 14 03/03/22, 20:48
pages.php:676should we remove the "size" here? -
Oli Bartsch uploaded patch set 15 03/03/22, 21:11
-
Oli Bartsch commented on patch set 15 03/03/22, 21:13
pages.php:676ReplyAs discussed, I would like to keep it here, since this otherwise differs to the "author" field which is in the same row. -
core-ci voted on patch set 15 V +1 03/03/22, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24529
-
Oli Bartsch updated the commit message in patch set 16 03/03/22, 21:20
-
core-ci voted on patch set 16 V +1 03/03/22, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24530
-
Benni Mack uploaded patch set 17 03/03/22, 21:48
-
Benni Mack voted on patch set 17 V +1 CR +1 03/03/22, 21:48
-
Oli Bartsch voted on patch set 17 V +1 CR +1 03/03/22, 21:55
-
core-ci voted on patch set 17 V +1 03/03/22, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24531
-
Andreas Kienast commented on patch set 17 CR -1 03/04/22, 07:24
on it -
Andreas Kienast uploaded patch set 18 03/04/22, 07:25
-
Andreas Kienast voted on patch set 18 V +1 CR +1 03/04/22, 07:25
-
Benni Mack voted on patch set 18 V +1 CR +1 03/04/22, 07:33
-
core-ci voted on patch set 18 V +1 03/04/22, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24539
-
Andreas Kienast voted on patch set 18 V +2 CR +2 03/04/22, 08:00
-
Andreas Kienast merged patch set 19 03/04/22, 08:01
BackendUtility.php:1686