73688[BUGFIX] Prevent YAML escaping from being displayed in form labels
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Björn Jacob +1
- Andreas Steiger +1
-
Verified V +2 Done
- Oliver Hader +2
- Björn Jacob +1
- Andreas Steiger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2937
Show 1012 earlier messages
-
waldhacker uploaded patch set 1 02/23/22, 22:24
-
core-ci voted on patch set 1 V +1 02/23/22, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24156
-
Björn Jacob updated the commit message in patch set 2 02/24/22, 06:36
-
Björn Jacob voted on patch set 2 V +1 CR +1 02/24/22, 06:39
-
core-ci voted on patch set 2 V +1 02/24/22, 06:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24160
-
Oliver Hader commented on patch set 2 02/24/22, 08:09
This looks like a perfect candidate for more tests.... ;) * `'label'` * `"label"` * `\'label` * `\"label` -
waldhacker commented on patch set 2 CR -1 02/24/22, 08:11
Reply
sure ;) -
waldhacker marked it work in progress 02/24/22, 08:11
-
Oliver Hader commented on patch set 2 02/24/22, 08:15
Oh, and `label: "Demo: Just a 'label'"` also would be a good test case (→ colon) -
waldhacker commented on patch set 2 02/24/22, 08:19
This change is ready for review.Reply
Merci, i will start to write unit tests for it (and fix the code) :) -
waldhacker marked it work in progress 02/24/22, 08:19
-
waldhacker uploaded patch set 3 02/24/22, 09:56
-
waldhacker marked it ready for review 02/24/22, 10:00
-
core-ci voted on patch set 3 V +1 02/24/22, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24170
-
Björn Jacob updated the commit message in patch set 4 02/24/22, 10:28
-
Björn Jacob commented on patch set 4 V +1 CR +1 02/24/22, 10:29
Applied the optimized commit message again. And tested it again with all the cases mentioned. -
Oliver Hader voted on patch set 4 CR -1 02/24/22, 10:42
-
Oliver Hader marked it work in progress 02/24/22, 10:42
-
Oliver Hader uploaded patch set 5 02/24/22, 10:46
-
core-ci voted on patch set 4 V +1 02/24/22, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24174
-
Oliver Hader commented on patch set 5 CR +1 02/24/22, 10:47
This change is ready for review.FormPersistenceManagerTest.php:593Previously quotes from properties other than `label` were trimmed - I don't know, which implications it has when not trimming them anymore... -
waldhacker commented on patch set 5 02/24/22, 10:49
FormPersistenceManagerTest.php:593Replygood point, I check it briefly -
Oliver Hader voted on patch set 5 V +1 02/24/22, 10:50
-
core-ci voted on patch set 5 V -1 02/24/22, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24177
-
waldhacker uploaded patch set 6 02/24/22, 11:26
-
waldhacker voted on patch set 6 CR -1 02/24/22, 11:31
-
waldhacker uploaded patch set 7 02/24/22, 11:32
-
core-ci voted on patch set 6 V -1 02/24/22, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24181
-
core-ci voted on patch set 7 V -1 02/24/22, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24182
-
waldhacker uploaded patch set 8 02/24/22, 11:45
-
core-ci voted on patch set 8 V +1 02/24/22, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24185
-
Andreas Steiger commented on patch set 8 V +1 CR +1 02/24/22, 15:00
Works really nice for me 👍 -
Björn Jacob voted on patch set 8 V +1 CR +1 02/24/22, 15:02
-
waldhacker commented on patch set 8 02/24/22, 17:25
FormPersistenceManagerTest.php:593ReplyDone -
Oliver Hader voted on patch set 8 V +2 CR +2 02/25/22, 12:45
-
Oliver Hader merged patch set 9 02/25/22, 12:46