73690[BUGFIX] Discard 'new' workspace element when deleting live
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+56 −55
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+47 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/deletingDefaultLanguageElementDiscardsConnectedLocalizedElement.csvnew+34 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/deletingDefaultLanguageElementDiscardsConnectedLocalizedElementChain.csvnew+34 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/ActionTest.php+55 −0
Review log 811
-
Christian Kuhn uploaded patch set 1 02/24/22, 09:48
-
core-ci voted on patch set 1 V -1 02/24/22, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24168
-
Christian Kuhn uploaded patch set 2 02/24/22, 10:03
-
core-ci voted on patch set 2 V +1 02/24/22, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24171
-
Stefan Bürk updated the commit message in patch set 3 02/24/22, 12:10
-
core-ci voted on patch set 3 V +1 02/24/22, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24188
-
Stefan Bürk voted on patch set 3 V +1 CR +1 02/24/22, 13:28
-
Benni Mack commented on patch set 3 V +1 CR +1 02/24/22, 13:48
-
Oli Bartsch voted on patch set 3 CR +1 02/24/22, 21:14
-
Christian Kuhn commented on patch set 3 V +2 CR +2 02/24/22, 21:31
DataHandler.php:4870Replyyes. that be_user ws changing is super ugly, we have it in a couple of places. it should go away. but that's a systematic issue in DH right now and can't be resolved with this patch. -
Christian Kuhn merged patch set 4 02/24/22, 21:31
DataHandler.php:4870