Review main Merged

73690[BUGFIX] Discard 'new' workspace element when deleting live

Christian Kuhn CR +2 V +2 Hard +226 −55 updated 02/24/22, 21:31

Commit message

Scenario:
* Create a page in live
* Create a default language content element in live
* Localize live page
* Select a workspace
* Localize the content element in workspaces, translate mode
* Select live workspace
* Delete default content element in live

When deleting the default language content element in live,
usually all translated content elements are deleted, too.
This does not work for content element translations that
have been created in workspaces (t3ver_state=1). Those
elements *should* be discarded, but are not.

The patch adds a method to DataHandler to take care of
discarding t3ver_state=1 translations in workspaces when
a live record is set to deleted, and adds two functional
tests to verify behavior.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 811

  1. Christian Kuhn uploaded patch set 1 02/24/22, 09:48

  2. core-ci voted on patch set 1 V -1 02/24/22, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24168

  3. Christian Kuhn uploaded patch set 2 02/24/22, 10:03

  4. core-ci voted on patch set 2 V +1 02/24/22, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24171

  5. Stefan Bürk updated the commit message in patch set 3 02/24/22, 12:10

  6. core-ci voted on patch set 3 V +1 02/24/22, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24188

  7. Stefan Bürk voted on patch set 3 V +1 CR +1 02/24/22, 13:28

  8. Benni Mack commented on patch set 3 V +1 CR +1 02/24/22, 13:48

    DataHandler.php:4870

    this is super-ugly :(
  9. Oli Bartsch voted on patch set 3 CR +1 02/24/22, 21:14

  10. Christian Kuhn commented on patch set 3 V +2 CR +2 02/24/22, 21:31

    DataHandler.php:4870 Reply

    yes. that be_user ws changing is super ugly, we have it in a couple of places. it should go away. but that's a systematic issue in DH right now and can't be resolved with this patch.
  11. Christian Kuhn merged patch set 4 02/24/22, 21:31