Review main Merged

73691[TASK] Deprecate order of validation message

Björn Jacob CR +2 V +2 Normal +120 −0 updated 02/24/22, 17:50

Commit message

The form framework ships a "date range validator". The validator can
for example be added via the form editor to the "date" form element.
Especially when it comes to this element, the order of the available
fields is not in line with all of the other form elements. The field
"Custom error message" (validationErrorMessage) is usually the last
field.

Since the order can only be adjusted by changing the key within the
form configuration, this patch adds according comments to the form
configuration. The breaking change will be done with TYPO3 13.0 to
further streamline the UI.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Andreas Steiger +1
    • Elias Häußler +1
  • Verified V +2 Done
    • waldhacker +2
    • Andreas Steiger +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Björn Jacob uploaded patch set 1 02/24/22, 10:18

  2. core-ci voted on patch set 1 V +1 02/24/22, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24172

  3. Elias Häußler voted on patch set 1 V +1 CR +1 02/24/22, 10:27

  4. Andreas Steiger voted on patch set 1 V +1 CR +1 02/24/22, 15:04

  5. waldhacker voted on patch set 1 V +2 CR +2 02/24/22, 17:49

  6. waldhacker merged patch set 2 02/24/22, 17:50