73692[TASK] Validate regex validator pattern in form editor
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Björn Jacob +1
- Tobias Jungmann +1
-
Verified V +2 Done
- waldhacker +2
- Björn Jacob +1
- Tobias Jungmann +1
- core-ci +1 CI
Issues 1
Files 34
- typo3/sysext/form/Configuration/Yaml/FormElements/AdvancedPassword.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Date.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Email.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Honeypot.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Number.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Password.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Telephone.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Text.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Textarea.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Url.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormSetup.yaml+2 −0
- typo3/sysext/form/Documentation/I/Config/proto/formEditor/Index.rst+4 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/formEditor/propertyCollections/validators/80/editors/200.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/formEditor/propertyCollections/validators/80.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/formEditor.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/formEditor/propertyCollections/validators/80/editors/200.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/formEditor/propertyCollections/validators/80.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/formEditor/propertyCollections/validators/80/editors/200.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/formEditor/propertyCollections/validators/80.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/formEditor.rst+1 −0
Show 14 more files
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Telephone/formEditor/propertyCollections/validators/80/editors/200.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Telephone/formEditor/propertyCollections/validators/80.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Telephone/formEditor.rst2+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/formEditor/propertyCollections/validators/80/editors/200.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/formEditor/propertyCollections/validators/80.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/formEditor.rst2+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/formEditor/propertyCollections/validators/80/editors/200.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/formEditor/propertyCollections/validators/80.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/formEditor.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Url/formEditor/propertyCollections/validators/80/editors/200.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Url/formEditor/propertyCollections/validators/80.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Url/formEditor.rst+1 −0
- typo3/sysext/form/Resources/Private/Language/Database.xlf2+17 −14
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/view-model.js+24 −0
Review log 1721
-
Elias Häußler uploaded patch set 1 02/24/22, 10:23
-
core-ci voted on patch set 1 V +1 02/24/22, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24173
-
Stefan Bürk commented on patch set 1 02/24/22, 12:03
Does this needs adoption from instances on upgrade in there form yamls ??? I would rather call this a FEATURE than a TASK - or do I miss something ? -
Elias Häußler commented on patch set 1 02/24/22, 14:29
Reply
No, this should not have an impact on existing `.form.yaml` files. It's more an additional "safety" layer to prevent editors from defining an invalid regex pattern leading to an exception to the frontend user. Since this is just one more step on the way to remove the RegularExpressionValidator from backend form editor (the deprecation already comes via https://review.typo3.org/c/Packages/TYPO3.CMS/+/73689), I'd say it's clearly a TASK. But maybe it's worth an Important RST that explains the background? Furthermore, the underlying check only respects "/" as regex delimiter (so for example #.+# is not "valid" here), which might lead to problems in some cases. We could add a hint on how to disable the newly introduced "safety check". -
Tobias Jungmann commented on patch set 1 CR -1 04/27/22, 09:51
formEditor.rst:111Indent is not correct.formEditor.rst:236IndentDatabase.xlf:293Used tabs instead of spaces. -
Tobias Jungmann voted on patch set 1 V +1 04/27/22, 09:56
-
Björn Jacob uploaded patch set 2 04/27/22, 11:01
-
Björn Jacob commented on patch set 2 04/27/22, 11:04
formEditor.rst:111ReplyDoneformEditor.rst:236ReplyDoneDatabase.xlf:293ReplyDone -
Tobias Jungmann voted on patch set 2 CR +1 04/27/22, 11:04
-
Tobias Jungmann voted on patch set 2 V +1 04/27/22, 11:06
-
Björn Jacob updated the commit message in patch set 3 04/27/22, 11:10
-
core-ci voted on patch set 2 V +1 04/27/22, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26501
-
core-ci voted on patch set 3 V +1 04/27/22, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26502
-
Björn Jacob voted on patch set 3 CR +1 04/27/22, 11:19
-
Björn Jacob updated the commit message in patch set 4 04/27/22, 11:19
-
Björn Jacob voted on patch set 4 CR +1 04/27/22, 11:20
-
core-ci voted on patch set 4 V +1 04/27/22, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26503
-
Björn Jacob commented on patch set 4 V +1 04/27/22, 12:27
Awesome. Tested with "0" and "/ba(na){2}/i". -
Tobias Jungmann voted on patch set 4 V +1 CR +1 04/27/22, 12:28
-
waldhacker voted on patch set 4 V +2 CR +2 04/27/22, 13:21
-
waldhacker merged patch set 5 04/27/22, 13:21