Review main Merged

73693[TASK] Fix the return type annotation of getIndpEnv

Oliver Klee CR +2 V +2 Easy +2 −12 updated 02/27/22, 14:30

Commit message

GeneralUtility::getIndpEnv can also return values other than string,
e.g., PATH_INFO might return null, and TYPO3_SSL will return a
bool. Also, _ARRAY will return an array of all possible scalar
values.

The return type annotation needs to correctly reflect that in order
for static type analysis to be able to work correctly when this
function is called.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Simon Gilli +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Simon Gilli +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1318

  1. Oliver Klee uploaded patch set 1 02/24/22, 11:37

  2. Oliver Klee updated the commit message in patch set 2 02/24/22, 11:38

  3. core-ci voted on patch set 1 V -1 02/24/22, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24183

  4. core-ci voted on patch set 2 V -1 02/24/22, 11:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24184

  5. Stefan Bürk commented on patch set 2 02/24/22, 11:57

    FYI/tip: Patch solved "two" ignore pattern so far, thus phpstan baseline must be updated and added to the patch: ``` Build/Scripts/runTests.sh -s phpstanGenerateBaseline ``` Not sure about 10.4 backport. Docblock/Typehints backports has been blocked to be backported to 10.4 already.
  6. Oliver Klee commented on patch set 2 02/24/22, 12:02

    Reply

    Thanks for the tip! On it. I hope that we can backport this (as it does not change any PHP-native type declarations).
  7. Oliver Klee uploaded patch set 3 02/24/22, 12:04

  8. Stefan Bürk commented on patch set 3 02/24/22, 12:06

    Reply

    Was just as info. From my side no block on the 10.4 backport. But to be honest, not reviewed it yet. Just looked into the pipeline error.
  9. core-ci voted on patch set 3 V -1 02/24/22, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24187

  10. Oliver Klee uploaded patch set 4 02/24/22, 12:17

  11. core-ci voted on patch set 4 V +1 02/24/22, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24189

  12. Christian Kuhn updated the commit message in patch set 5 02/24/22, 12:26

  13. core-ci voted on patch set 5 V +1 02/24/22, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24191

  14. Simon Gilli voted on patch set 5 V +1 CR +1 02/26/22, 13:12

  15. Georg Ringer voted on patch set 5 V +1 CR +1 02/26/22, 13:22

  16. Stefan Bürk voted on patch set 5 V +1 CR +1 02/26/22, 13:29

  17. Christian Kuhn voted on patch set 5 V +2 CR +2 02/27/22, 14:30

  18. Christian Kuhn merged patch set 6 02/27/22, 14:30