73694[TASK] Create Extbase validators using ValidatorResolver
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 9
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+1 −2
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php7+6 −19
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+12 −4
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+8 −11
- typo3/sysext/form/Classes/Mvc/Property/PropertyMappingConfiguration.php+5 −2
- typo3/sysext/form/Classes/Mvc/ProcessingRule.php+8 −6
- typo3/sysext/form/Configuration/Services.yaml+3 −0
- typo3/sysext/form/Tests/Unit/Mvc/Property/PropertyMappingConfigurationTest.php+14 −4
- typo3/sysext/form/Tests/Unit/Mvc/ProcessingRuleTest.php+31 −14
Review log 2129
Show 24 earlier messages
-
Christian Kuhn uploaded patch set 1 02/24/22, 12:23
-
core-ci voted on patch set 1 V -1 02/24/22, 12:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24190
-
core-ci commented on patch set 1 02/24/22, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24190
-
Christian Kuhn uploaded patch set 2 02/24/22, 18:10
-
core-ci voted on patch set 2 V -1 02/24/22, 18:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24215
-
core-ci commented on patch set 2 02/24/22, 22:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24215
-
Christian Kuhn rebased onto patch set 3 02/24/22, 22:04
-
core-ci voted on patch set 3 V -1 02/24/22, 22:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24240
-
Christian Kuhn uploaded patch set 4 02/24/22, 22:44
-
Christian Kuhn updated the commit message in patch set 5 02/24/22, 22:51
-
core-ci voted on patch set 5 V +1 02/24/22, 22:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24242
-
Stefan Bürk voted on patch set 5 V +1 CR +1 02/24/22, 23:27
-
Oli Bartsch commented on patch set 5 02/25/22, 00:25
-
Christian Kuhn commented on patch set 5 02/25/22, 00:27
ValidatorResolver.php:54Replyimho does not make sense to have a dedicated class with a single method that does not do much at the moment. createValidator() is api for a while, i'd say we could keep it to not be breaking without issues at the moment? -
Oli Bartsch commented on patch set 5 02/25/22, 00:34
ValidatorResolver.php:54ReplyBasically that's the same for ModuleTemplateFactory. ValidatorResolver is also marked as @internal, so this shouldn't be breaking, right? However, no blocker for me, just spotted the @todo and considered it valid. :) -
Christian Kuhn commented on patch set 5 02/25/22, 00:49
ValidatorResolver.php:54Replyyeah. not strictly breaking. would keep it as is for now, though. -
Oli Bartsch commented on patch set 5 02/25/22, 01:18
ValidatorResolver.php:54ReplyAck -
Benni Mack commented on patch set 5 02/25/22, 06:31
ValidatorResolver.php:54ReplySo basically the resolver is the factory :) -
Benni Mack commented on patch set 5 02/25/22, 06:31
factory method is a different design pattern, I guess you mean just "using ValidatorResolver"? -
Christian Kuhn commented on patch set 5 03/03/22, 08:17
Reply
DoneValidatorResolver.php:54Replyremoved the @todo now. -
Christian Kuhn uploaded patch set 6 03/03/22, 08:18
-
core-ci voted on patch set 6 V -1 03/03/22, 08:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24495
-
Christian Kuhn uploaded patch set 7 03/03/22, 08:37
-
core-ci voted on patch set 7 V +1 03/03/22, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24497
-
Stefan Bürk voted on patch set 7 CR +1 03/03/22, 09:25
-
Benni Mack voted on patch set 7 V +1 CR +1 03/03/22, 09:42
-
Stefan Bürk voted on patch set 7 V +1 03/03/22, 09:46
-
Christian Kuhn voted on patch set 7 V +2 CR +2 03/03/22, 10:00
-
Christian Kuhn merged patch set 8 03/03/22, 10:00
ValidatorResolver.php:54