Review main Merged

73695[TASK] Further improvements of the form editor/ inspector

Tobias Siegler CR +2 V +2 Hard +222 −127 updated 04/28/22, 14:00

Commit message

The markup of the field definitions has been optimized and aligned
with the standard styling (e.g. in the page properties). Available
info texts have also been adjusted.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Andreas Steiger +1
    • Elias Häußler +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Andreas Steiger +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 2230

Show 35 earlier messages
  1. Tobias Siegler uploaded patch set 1 02/24/22, 12:40

  2. core-ci voted on patch set 1 V +1 02/24/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24192

  3. Tobias Siegler rebased onto patch set 2 02/25/22, 14:47

  4. core-ci voted on patch set 2 V +1 02/25/22, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24283

  5. Tobias Siegler uploaded patch set 3 02/25/22, 15:02

  1. core-ci voted on patch set 3 V +1 02/25/22, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24285

  2. waldhacker marked it work in progress 02/26/22, 15:18

  3. Tobias Siegler uploaded patch set 4 04/27/22, 10:33

  4. core-ci voted on patch set 4 V +1 04/27/22, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26498

  5. Tobias Siegler uploaded patch set 5 04/27/22, 15:33

  6. core-ci voted on patch set 5 V +1 04/27/22, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26522

  7. Björn Jacob updated the commit message in patch set 6 04/28/22, 08:29

  8. Tobias Siegler marked it ready for review 04/28/22, 08:31

  9. Andreas Steiger voted on patch set 6 V +1 CR +1 04/28/22, 08:40

  10. core-ci voted on patch set 6 V -1 04/28/22, 08:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26561

  11. Elias Häußler commented on patch set 6 04/28/22, 08:54

    FinishersEditor.html:3

    `form-group` is added twice

    ValidationErrorMessageEditor.html:8

    Is the nested `t3-form-controls` class intended?
  12. Björn Jacob commented on patch set 6 CR -1 04/28/22, 08:55

    Can you please provide two or three sentences what the patch does? Please add it to the commit message.
  13. Elias Häußler commented on patch set 6 04/28/22, 09:03

    CheckboxEditor.html:10

    This <div> should be removed (probably using JS) if no explanationText is defined. Otherwise, this generates too much space between elements in the inspector.
  14. Elias Häußler commented on patch set 6 04/28/22, 09:11

    CheckboxEditor.html:13

    In FormEngine, descriptions are placed between label and checkbox. Maybe we should streamline this with the form editor as well.
  15. Elias Häußler voted on patch set 6 CR -1 04/28/22, 09:11

  16. Tobias Siegler uploaded patch set 7 04/28/22, 11:23

  17. Tobias Siegler commented on patch set 6 04/28/22, 11:25

    CheckboxEditor.html:10 Reply

    By moving the description between label and checkbox (your other comment), this problem has become obsolete.

    CheckboxEditor.html:13 Reply

    Done

    FinishersEditor.html:3 Reply

    Done

    ValidationErrorMessageEditor.html:8 Reply

    It's not needed, was my mistake.
  18. core-ci voted on patch set 7 V +1 04/28/22, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26579

  19. Tobias Siegler updated the commit message in patch set 8 04/28/22, 11:39

  20. core-ci voted on patch set 8 V +1 04/28/22, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26582

  21. Elias Häußler voted on patch set 8 V +1 CR +1 04/28/22, 13:30

  22. Andreas Steiger voted on patch set 8 V +1 CR +1 04/28/22, 13:32

  23. Björn Jacob voted on patch set 8 V +1 CR +1 04/28/22, 13:42

  24. waldhacker voted on patch set 8 V +2 CR +2 04/28/22, 13:59

  25. waldhacker merged patch set 9 04/28/22, 14:00