Review main Merged Breaking

73698[!!!][TASK] Always render frontend in UTF-8

Benni Mack CR +2 V +2 Hard +94 −171 updated 03/03/22, 10:33

Commit message

This removes the option config.metaCharset and the
conversion of content everywhere.

The public method "TSFE->convOutputCharset" is gone.
The property "config.metaCharset" has no effect anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 1724

  1. Benni Mack uploaded patch set 1 02/24/22, 13:25

  2. core-ci voted on patch set 1 V -1 02/24/22, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24196

  3. Benni Mack uploaded patch set 2 02/24/22, 16:30

  4. core-ci voted on patch set 2 V -1 02/24/22, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24205

  5. Benni Mack uploaded patch set 3 02/24/22, 18:48

  6. core-ci voted on patch set 3 V +1 02/24/22, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24223

  7. Benni Mack uploaded patch set 4 02/28/22, 22:14

  8. Benni Mack rebased onto patch set 5 03/01/22, 09:04

  9. core-ci voted on patch set 5 V +1 03/01/22, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24407

  10. Benni Mack uploaded patch set 6 03/02/22, 22:05

  11. Benni Mack uploaded patch set 7 03/02/22, 22:07

  12. core-ci voted on patch set 7 V +1 03/02/22, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24481

  13. Oli Bartsch commented on patch set 7 03/03/22, 00:16

    PageRenderer.php:2380

    Should we change this to "Language is not set."?

    Breaking-97065-TYPO3FrontendAlwaysRenderedInUTF-8.rst:36

    We might want to mention extension scanner coverage.

    Breaking-97065-TYPO3FrontendAlwaysRenderedInUTF-8.rst:55

    "Any usage of the removed property / method should be removed."
  14. Benni Mack uploaded patch set 8 03/03/22, 07:21

  15. core-ci voted on patch set 8 V -1 03/03/22, 07:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24490

  16. Benni Mack uploaded patch set 9 03/03/22, 07:54

  17. core-ci voted on patch set 9 V +1 03/03/22, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24494

  18. Benni Mack commented on patch set 9 03/03/22, 09:42

    PageRenderer.php:2380 Reply

    Done

    Breaking-97065-TYPO3FrontendAlwaysRenderedInUTF-8.rst:36 Reply

    Done

    Breaking-97065-TYPO3FrontendAlwaysRenderedInUTF-8.rst:55 Reply

    Done
  19. Oli Bartsch voted on patch set 9 V +1 CR +1 03/03/22, 10:26

  20. Susi Moog voted on patch set 9 CR +1 03/03/22, 10:29

  21. Susi Moog voted on patch set 9 V +1 03/03/22, 10:30

  22. Stefan Bürk voted on patch set 9 V +1 CR +1 03/03/22, 10:32

  23. Benni Mack voted on patch set 9 V +2 CR +2 03/03/22, 10:33

  24. Benni Mack merged patch set 10 03/03/22, 10:33