Review main Merged

73699[BUGFIX] Recognize changes in FlexForm section containers

Elias Häußler CR +2 V +2 Easy +5 −2 updated 02/24/22, 19:37

Commit message

If section containers are changed (i.e. new containers are added or
existing ones are deleted), the change is now recognized by adding a
class `has-change` to the appropriate container. This assures the
modal on exit is shown to the backend user to avoid discarding
onsaved changes.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • waldhacker +1
    • Andreas Steiger +1
  • Verified V +2 Done
    • Oliver Hader +2
    • waldhacker +1
    • Andreas Steiger +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1011

  1. Elias Häußler uploaded patch set 1 02/24/22, 13:47

  2. core-ci voted on patch set 1 V +1 02/24/22, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24197

  3. Oliver Hader commented on patch set 1 02/24/22, 13:58

    Is this just a visual change in the UI? I did not find any occurrence in the core, checking whether the 'has-change' is set - e.g. `classList.containt('has-change')`
  4. Oliver Hader commented on patch set 1 02/24/22, 14:00

    Forget it, the counter-part is `FormEngine.hasChange()`
  5. Elias Häußler commented on patch set 1 02/24/22, 14:02

    Reply

    yep, `FormEngine.hasChange` evaluates whether `has-change` is set anywhere and if so, `FormEngine.preventExitIfNotSaved` is called
  6. Oliver Hader voted on patch set 1 V +1 CR +1 02/24/22, 14:09

  7. Oliver Hader commented on patch set 1 02/24/22, 14:10

    Good catch!
  8. Andreas Steiger commented on patch set 1 V +1 CR +1 02/24/22, 15:28

    Nice!
  9. waldhacker voted on patch set 1 V +1 CR +1 02/24/22, 18:59

  10. Oliver Hader voted on patch set 1 V +2 CR +2 02/24/22, 19:37

  11. Oliver Hader merged patch set 2 02/24/22, 19:37