73699[BUGFIX] Recognize changes in FlexForm section containers
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- waldhacker +1
- Andreas Steiger +1
-
Verified V +2 Done
- Oliver Hader +2
- waldhacker +1
- Andreas Steiger +1
- core-ci +1 CI
Issues 1
Files 4
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-container-container.ts+1 −0
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-section-container.ts+2 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/flex-form-container-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/flex-form-section-container.js+1 −1
Review log 1011
-
Elias Häußler uploaded patch set 1 02/24/22, 13:47
-
core-ci voted on patch set 1 V +1 02/24/22, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24197
-
Oliver Hader commented on patch set 1 02/24/22, 13:58
Is this just a visual change in the UI? I did not find any occurrence in the core, checking whether the 'has-change' is set - e.g. `classList.containt('has-change')` -
Oliver Hader commented on patch set 1 02/24/22, 14:00
Forget it, the counter-part is `FormEngine.hasChange()` -
Elias Häußler commented on patch set 1 02/24/22, 14:02
Reply
yep, `FormEngine.hasChange` evaluates whether `has-change` is set anywhere and if so, `FormEngine.preventExitIfNotSaved` is called -
Oliver Hader voted on patch set 1 V +1 CR +1 02/24/22, 14:09
-
Oliver Hader commented on patch set 1 02/24/22, 14:10
Good catch! -
Andreas Steiger commented on patch set 1 V +1 CR +1 02/24/22, 15:28
Nice! -
waldhacker voted on patch set 1 V +1 CR +1 02/24/22, 18:59
-
Oliver Hader voted on patch set 1 V +2 CR +2 02/24/22, 19:37
-
Oliver Hader merged patch set 2 02/24/22, 19:37