73701[DOCS] Add FAQ about duplicate form submission
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Mathias Brodala +1
- Elias Häußler +1
-
Verified V +2 Done
- waldhacker +2
- Mathias Brodala +1
- Elias Häußler +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2125
-
Björn Jacob uploaded patch set 1 02/24/22, 14:26
-
Elias Häußler commented on patch set 1 02/24/22, 14:32
-
core-ci voted on patch set 1 V +1 02/24/22, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24199
-
Björn Jacob commented on patch set 2 02/24/22, 14:35
Published edit on patch set 1. -
Oliver Hader commented on patch set 2 02/24/22, 14:40
Index.rst:107ReplyIt better, since it avoid approaching readers directly "YOU as a reader". What do you think about adding some simple JavaScript example to deny double submissions? For example ``` document.getElementById('myform-123') .addEventListener('submit', (evt) => this.querySelectorAll('input[type="submit"]') .forEach((el) => el.setAttribute('disabled', 'disabled')) ``` -
core-ci voted on patch set 2 V +1 02/24/22, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24201
-
Colin Findeisen commented on patch set 2 V +1 CR +1 02/24/22, 15:37
Looks good. -
Stefan Bürk commented on patch set 2 02/24/22, 17:12
Isn't this a little bit confusing ... Right, core do not ship frontend stuff, and should not. That's good. Anyway ... the form documentation now says "we do not deliever a solution here" .. and just some sentence below for the datepicker "to use full potentialy use jquery and the plugin" (providing a solution for the frontend). I mean .. if there is already a "choseable" solution for the "datetime" thing, maybe at least a "jquery" js example as "help" whould be the minimun instead of contra sayings in just a view sentencens ... or not ? -
Björn Jacob voted on patch set 2 CR -1 02/24/22, 17:12
-
Stefan Bürk commented on patch set 2 02/24/22, 17:13
Index.rst:107ReplyNot read that .. ack to what oliver said is my thought too. At least a example snippet should be written. -
Björn Jacob uploaded patch set 3 02/24/22, 17:41
-
Björn Jacob commented on patch set 3 02/24/22, 17:42
All done. Added the example. Did the rendering. Looks very fine to me. Thank you for your input guys!Index.rst:107ReplyDone -
core-ci voted on patch set 3 V +1 02/24/22, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24211
-
Mathias Brodala commented on patch set 3 02/25/22, 08:01
Index.rst:118I'd rather link to an external page which discusses this in more detail. Aside from that: 1. What about button[type="submit"]? 2. Can we suggest arrow functions without transpilers? 3. Wouldn't "this" be "window" here since the arrow function prevents scoping? 4. Should we consider "submitter"? (https://developer.mozilla.org/en-US/docs/Web/API/SubmitEvent) -
Björn Jacob commented on patch set 3 02/25/22, 08:08
Index.rst:118ReplyI have no feelings regarding this example. I am not able to create an example which suits all of your ideas. Could you provide an example? Would be highly appreciated. -
Mathias Brodala commented on patch set 3 02/25/22, 08:28
Index.rst:118ReplyHow about this: document.getElementById('myform-123') .addEventListener('submit', function(e) { e.target.querySelectorAll('[type="submit"]') .forEach(function(button) { button.disabled = true; }); }); This avoids the arrow functions and makes actual use of the SubmitEvent for definite button lookup within the form. It also grabs all kind of submit controls, so input and button. -
Björn Jacob commented on patch set 3 CR -1 02/25/22, 09:48
On it. -
Björn Jacob uploaded patch set 4 02/25/22, 09:54
-
Björn Jacob commented on patch set 4 02/25/22, 09:55
Index.rst:118ReplyDone -
Mathias Brodala commented on patch set 4 V +1 CR +1 02/25/22, 09:58
Thanks. :-) -
Elias Häußler voted on patch set 4 V +1 CR +1 02/25/22, 10:01
-
core-ci voted on patch set 4 V +1 02/25/22, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24256
-
waldhacker voted on patch set 4 V +2 CR +2 02/25/22, 10:05
-
waldhacker merged patch set 5 02/25/22, 10:05
Index.rst:107