73703[BUGFIX] Fix HMENU / LanguageMenuProcessor for translated pages
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Markus Klein +1
- Thorben Nissen +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Markus Klein +1
- Thorben Nissen +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1318
-
Benni Mack uploaded patch set 1 02/24/22, 18:16
-
Benni Mack updated the commit message in patch set 2 02/24/22, 18:21
-
Benni Mack updated the commit message in patch set 3 02/24/22, 18:22
-
core-ci voted on patch set 1 V +1 02/24/22, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24216
-
core-ci voted on patch set 3 V +1 02/24/22, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24219
-
core-ci voted on patch set 2 V +1 02/24/22, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24218
-
Thorben Nissen commented on patch set 3 V +1 CR +1 02/25/22, 08:11
Still not sure, if it is necessary to change the argument from int to array. Though preparing for a future adjustment of `PageRepository::getPageOverlay` is fine with me. I tested the change in my project and it works as expected. -
Markus Klein commented on patch set 3 V +1 CR +1 03/07/22, 09:52
Works! Thanks -
Benni Mack uploaded patch set 4 03/07/22, 11:33
-
Benni Mack commented on patch set 4 03/07/22, 11:33
Please re-vote. I added some tests. -
Oli Bartsch updated the commit message in patch set 5 03/07/22, 11:36
-
core-ci voted on patch set 4 V +1 03/07/22, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24654
-
core-ci voted on patch set 5 V +1 03/07/22, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24655
-
Oli Bartsch voted on patch set 5 V +1 CR +1 03/07/22, 11:52
-
Markus Klein voted on patch set 5 V +1 CR +1 03/07/22, 11:52
-
Thorben Nissen voted on patch set 5 V +1 CR +1 03/07/22, 11:56
-
Benni Mack voted on patch set 5 V +2 CR +2 03/07/22, 12:02
-
Benni Mack merged patch set 6 03/07/22, 12:02