Review main Merged

73707[TASK] Add expressive API to ProcessingRule class

Helmut Hummel CR +2 V +2 Normal +104 −14 updated 02/25/22, 12:07

Commit message

As a followup to #96424, expressive API is introduced
and covered with unit tests, to better convey the
intention in the places it is used.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Elias Häußler +1
  • Verified V +2 Done
    • waldhacker +2
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 68

  1. Helmut Hummel uploaded patch set 1 02/24/22, 21:44

  2. core-ci voted on patch set 1 V -1 02/24/22, 21:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24237

  3. Elias Häußler uploaded patch set 2 02/25/22, 10:14

  4. Elias Häußler commented on patch set 2 V +1 CR +1 02/25/22, 10:16

    Thanks for the followup, Helmut! I'm not sure if we need this in 11.5 as well, but in any case – LGTM.
  5. core-ci voted on patch set 2 V +1 02/25/22, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24258

  6. Helmut Hummel commented on patch set 2 02/25/22, 11:21

    Reply

    Yeah it is not super important for 11.5, but I think it makes sense still to have this aligned at this point in the lifecycle of 11 LTS
  7. waldhacker voted on patch set 2 V +2 CR +2 02/25/22, 12:05

  8. waldhacker merged patch set 3 02/25/22, 12:07