73707[TASK] Add expressive API to ProcessingRule class
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Elias Häußler +1
-
Verified V +2 Done
- waldhacker +2
- Elias Häußler +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+1 −4
- typo3/sysext/form/Classes/Mvc/Property/PropertyMappingConfiguration.php+11 −7
- typo3/sysext/form/Classes/Mvc/ProcessingRule.php+27 −0
- typo3/sysext/form/Tests/Unit/Mvc/Fixtures/AnotherTestValidator.phpnew+33 −0
- typo3/sysext/form/Tests/Unit/Mvc/ProcessingRuleTest.php+32 −3
Review log 68
-
Helmut Hummel uploaded patch set 1 02/24/22, 21:44
-
core-ci voted on patch set 1 V -1 02/24/22, 21:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24237
-
Elias Häußler uploaded patch set 2 02/25/22, 10:14
-
Elias Häußler commented on patch set 2 V +1 CR +1 02/25/22, 10:16
Thanks for the followup, Helmut! I'm not sure if we need this in 11.5 as well, but in any case – LGTM. -
core-ci voted on patch set 2 V +1 02/25/22, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24258
-
Helmut Hummel commented on patch set 2 02/25/22, 11:21
Reply
Yeah it is not super important for 11.5, but I think it makes sense still to have this aligned at this point in the lifecycle of 11 LTS -
waldhacker voted on patch set 2 V +2 CR +2 02/25/22, 12:05
-
waldhacker merged patch set 3 02/25/22, 12:07