Review main Merged

73708[TASK] Remove "log" submodule from web_info

Oli Bartsch CR +2 V +2 Normal +51 −151 updated 02/25/22, 21:56

Commit message

Previously, the Belog module was accessible in System>Log
as well as a third-level module in web>info. Latter required
a couple of hacks, e.g. a manual extbase bootstrap.

To simplify the underlying codebase, the "log" submodule
is now removed from web_info.

The main benefit of the log module in web>info was the
usage of the page tree to filter logs by page. This
feature will be added to the System>Log module in
another patch again.

Also note that since TYPO3 v9 ist also possible
to access relevant page and record logs in the
history module.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1419

  1. Oli Bartsch uploaded patch set 1 02/24/22, 22:24

  2. core-ci voted on patch set 1 V -1 02/24/22, 22:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24241

  3. Oli Bartsch uploaded patch set 2 02/24/22, 23:04

  4. core-ci voted on patch set 2 V +1 02/24/22, 23:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24243

  5. Oli Bartsch uploaded patch set 3 02/25/22, 00:13

  6. core-ci voted on patch set 3 V +1 02/25/22, 00:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24244

  7. Oli Bartsch uploaded patch set 4 02/25/22, 16:07

  8. core-ci voted on patch set 4 V +1 02/25/22, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24294

  9. Benni Mack voted on patch set 4 CR +1 02/25/22, 16:33

  10. Benni Mack voted on patch set 4 V +1 02/25/22, 16:41

  11. Benjamin Franzke commented on patch set 4 V -1 02/25/22, 16:48

    Hm.. How do I access the logs of a specific page via the History module? I fail to do so, or is that an option or so? I mean, there is the context-menu entry "History/Undo", but I don't think you refer to that one, as that's a very different view.
  12. Benjamin Franzke commented on patch set 4 02/25/22, 16:50

    Reply

    Should we add a page-filter to the history module first?
  13. Oli Bartsch uploaded patch set 5 02/25/22, 20:01

  14. Oli Bartsch commented on patch set 5 02/25/22, 20:02

    Reply

    As discussed in slack, I added a @todo to add a pageId filter to the module again.
  15. core-ci voted on patch set 5 V +1 02/25/22, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24304

  16. Benjamin Franzke voted on patch set 5 V +1 CR +1 02/25/22, 20:27

  17. Benni Mack voted on patch set 5 V +1 CR +1 02/25/22, 21:50

  18. Oli Bartsch voted on patch set 5 V +2 CR +2 02/25/22, 21:56

  19. Oli Bartsch merged patch set 6 02/25/22, 21:56