Review TYPO3_4-6 Merged

7371[BUGFIX] PHP warning if open_basedir is enabled

Markus Klein CR +2 V +2 Easy +7 −3 updated 06/03/13, 20:49

Commit message

When using flexforms, a warning may appear in the Backend when
saving the form in BE (typically in a plugin). This happens
because TYPO3 checks if flexform DS is static (in the file)
using is_file. When the DS is not static, the parameter
to is_file is not a file name but an XML content. PHP
thinks this "file name" falls outside of the open_basedir
and complains with a warning. Possibly it can be solved
in other ways but this fix is the simplest possible.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2
    • Steffen Ritter +2
    • Markus Klein +1

Issues 1

Files 1

Review log 9

  1. Stefan Neufeind uploaded patch set 2 01/19/12, 06:11

  2. Stefan Neufeind commented on patch set 2 01/19/12, 06:11

    I would prefer that you didn't submit this sorry for that. Just wanted to get rid of the newline at end of t3lib/class.t3lib_befunc.php and now the submodule-pointers slipped in :-(
  3. Stefan Neufeind uploaded patch set 3 01/19/12, 06:11

  4. Stefan Neufeind commented on patch set 3 01/19/12, 06:11

    Looks good to me, but someone else must approve same patch as already merged in master. just some indentions adjusted. From patch 1 to patch 3 I just removed the newline at file-end.
  5. Markus Klein commented on patch set 1 01/19/12, 06:11

    Verified; Looks good to me, but someone else must approve
  6. Markus Klein commented on patch set 3 01/19/12, 06:11

    Verified; Looks good to me, but someone else must approve
  7. Oliver Klee commented on patch set 3 01/19/12, 06:11

    Looks good to me, but someone else must approve
  8. Steffen Ritter commented on patch set 3 V 0 01/19/12, 06:11

    by team member; Looks good to me, approved verified on master, patch equals
  9. Steffen Ritter merged patch set 3 01/19/12, 06:11