7371[BUGFIX] PHP warning if open_basedir is enabled
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Stefan Neufeind +1
- Oliver Klee +1
- Markus Klein +1
-
Verified V +2
- Steffen Ritter +2
- Markus Klein +1
Issues 1
Files 1
Review log 9
-
Stefan Neufeind uploaded patch set 2 01/19/12, 06:11
-
Stefan Neufeind commented on patch set 2 01/19/12, 06:11
I would prefer that you didn't submit this sorry for that. Just wanted to get rid of the newline at end of t3lib/class.t3lib_befunc.php and now the submodule-pointers slipped in :-( -
Stefan Neufeind uploaded patch set 3 01/19/12, 06:11
-
Stefan Neufeind commented on patch set 3 01/19/12, 06:11
Looks good to me, but someone else must approve same patch as already merged in master. just some indentions adjusted. From patch 1 to patch 3 I just removed the newline at file-end. -
Markus Klein commented on patch set 1 01/19/12, 06:11
Verified; Looks good to me, but someone else must approve -
Markus Klein commented on patch set 3 01/19/12, 06:11
Verified; Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 3 01/19/12, 06:11
Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 3 V 0 01/19/12, 06:11
by team member; Looks good to me, approved verified on master, patch equals -
Steffen Ritter merged patch set 3 01/19/12, 06:11