Review 11.5 Merged

73711[TASK] Add expressive API to ProcessingRule class

waldhacker CR +2 V +2 Normal +109 −12 updated 03/04/22, 19:26

Commit message

As a followup to #96424, expressive API is introduced
and covered with unit tests, to better convey the
intention in the places it is used.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • waldhacker +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • waldhacker +1
    • Björn Jacob +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. waldhacker uploaded patch set 1 02/25/22, 12:15

  2. core-ci voted on patch set 1 V -1 02/25/22, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24265

  3. waldhacker commented on patch set 2 02/25/22, 12:31

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V -1 02/25/22, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24266

  5. waldhacker uploaded patch set 3 02/25/22, 12:50

  6. core-ci voted on patch set 3 V +1 02/25/22, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24269

  7. waldhacker voted on patch set 3 V +1 CR +1 02/26/22, 18:52

  8. Björn Jacob voted on patch set 3 V +1 CR +1 03/04/22, 15:31

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 03/04/22, 19:26

  10. Christian Kuhn merged patch set 4 03/04/22, 19:26