Review 11.5 Merged

73712[BUGFIX] Prevent YAML escaping from being displayed in form labels

Oliver Hader CR +2 V +2 Normal +74 −2 updated 02/25/22, 13:30

Commit message

To make the form manager and form plugins load faster,
the patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/58054/
optimized the parsing of form definitions. Instead of using the
YAML parser, a very rudimentary "parser" was introduced. This works
fine, except for the fact that YAML escapes in form labels
are not unescaped when displayed.

This patch partially reintroduces the parsing of YAML, but only for
the label.

The performance drops only slightly.

10000x "loadMetaData()" (status quo) = 0.41 seconds
10000x "loadMetaData()" + parse label with yaml parser = 0.57 seconds
10000x parse the whole form definition with yaml parser = 7.57 seconds

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 02/25/22, 12:46

  2. core-ci voted on patch set 1 V +1 02/25/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24268

  3. Oliver Hader voted on patch set 1 V +2 CR +2 02/25/22, 13:30

  4. Oliver Hader merged patch set 2 02/25/22, 13:30