Review main Abandoned

73716[BUGFIX] Respect datetime dbtype field

TYPO3com CR 0 V 0 Easy +2 −2 updated 02/04/23, 11:17

Commit message

If TCA uses dbtype=datetime, it is converted to int and ends in invalid
timestamp. This fix prevents this and shows the correct date in history
view.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 710

  1. TYPO3com uploaded patch set 1 02/25/22, 14:05

  2. core-ci voted on patch set 1 V +1 02/25/22, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24280

  3. Benni Mack updated the commit message in patch set 2 02/25/22, 15:05

  4. core-ci voted on patch set 2 V +1 02/25/22, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24286

  5. Benni Mack voted on patch set 2 CR +1 03/01/22, 12:17

  6. Christian Wolff voted on patch set 2 CR +1 05/06/22, 12:06

  7. Oliver Klee commented on patch set 2 05/06/22, 12:29

    BackendUtility.php:1623 Unresolved

    I'd really prefer this to be covered by an automated test.
  8. Oli Bartsch commented on patch set 2 CR -1 05/09/22, 08:37

    BackendUtility.php:1622 Unresolved

    I don't understand the purpose of this patch. dbType=datetime is already handled in L:1667. Therefore, the "eval" has to match. This means, using "eval=date" with "dbType=datetime" is wrong in my opinion and should therefore not be handled here. Besides, this part has been refactored on introduction of TCA type "datetime", and should if at all, only be relevant for 11.5
  9. Christian Kuhn commented on patch set 2 02/04/23, 11:17

    hey. i hope it's ok to abandon here for the time being: the patch is stuck for quite a while and it looks as if the issue has been taken care off differently, meanwhile.
  10. Christian Kuhn abandoned the change 02/04/23, 11:17