Review main Merged

73722[TASK] Add functional tests to test the caching behavior of ext:form

waldhacker CR +2 V +2 Expert +1419 −0 updated 06/03/22, 17:21

Commit message

In preparation for patchset
https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460/,
functional tests are introduced to test the caching behavior
of EXT:form.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 26

Show 6 more files

Review log 2741

Show 916 earlier messages
  1. waldhacker uploaded patch set 1 02/25/22, 17:10

  2. core-ci voted on patch set 1 V -1 02/25/22, 17:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24299

  3. Björn Jacob commented on patch set 1 02/25/22, 19:46

    IMHO this has to be related to #93887 and not to the issue #70...
  4. waldhacker updated the commit message in patch set 2 02/26/22, 08:03

  5. core-ci voted on patch set 2 V +1 02/26/22, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24314

  6. Oliver Hader uploaded patch set 3 02/26/22, 09:40

  7. core-ci voted on patch set 3 V -1 02/26/22, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24316

  8. Oliver Hader uploaded patch set 4 02/26/22, 09:51

  9. core-ci voted on patch set 4 V +1 02/26/22, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24317

  10. waldhacker uploaded patch set 5 02/26/22, 12:39

  11. core-ci voted on patch set 5 V +1 02/26/22, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24321

  12. waldhacker commented on patch set 6 02/26/22, 12:48

    Published edit on patch set 5.
  13. core-ci voted on patch set 6 V +1 02/26/22, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24322

  14. waldhacker uploaded patch set 7 02/26/22, 17:43

  15. core-ci voted on patch set 7 V +1 02/26/22, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24336

  16. Stefan Bürk commented on patch set 7 CR -1 03/04/22, 19:41

    on it
  1. Stefan Bürk uploaded patch set 8 03/04/22, 20:00

  2. core-ci voted on patch set 8 V +1 03/04/22, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24586

  3. Stefan Bürk commented on patch set 8 CR -1 03/04/22, 20:11

    See comment for typo3/sysext/form/Tests/Functional/RequestHandling/AbstractRequestHandlingTest.php

    AbstractRequestHandlingTest.php:193

    Not a good way to "simply" copy tf methods to core. Opening a PR in tf before hand would be the better way. Same for "retrieveFrontendSubRequestResult()" below. However, this has been added to testing-framework now. These methods should be removed and InternalRequest() propely filled. See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73767 This adds tests for POST, PUT, PACH and DELETE requests with data submission.
  4. Christian Kuhn commented on patch set 8 03/04/22, 20:33

    AbstractRequestHandlingTest.php:193 Reply

    agreed. we just fixed that in TF (v6, too), so it should be fine to not override her.
  5. Stefan Bürk uploaded patch set 9 03/04/22, 23:27

  6. core-ci voted on patch set 9 V +1 03/04/22, 23:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24595

  7. Stefan Bürk uploaded patch set 10 03/04/22, 23:53

  8. Stefan Bürk commented on patch set 10 03/05/22, 00:00

    DataPusher.php:27

    Can we find a name which match properly what this class does or is for ? It do not push anything anyware. It just holds the data to be "used" or transformed eventually. Added a "class comment" but maybe can be changed accordingly.

    AbstractRequestHandlingTest.php:193 Reply

    Done

    RequestHandlingTest.php:252

    superflous - not used later and do not serve any checks/data prepartion.

    RequestHandlingTest.php:264

    unused

    RequestHandlingTest.php:265

    unused

    RequestHandlingTest.php:346

    unused - can be removed.

    RequestHandlingTest.php:354

    unused - can be removed.
  9. core-ci voted on patch set 10 V +1 03/05/22, 00:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24598

  10. waldhacker uploaded patch set 11 04/28/22, 13:22

  11. waldhacker commented on patch set 11 04/28/22, 13:27

    DataPusher.php:27 Reply

    Done

    AbstractRequestHandlingTest.php:193 Reply

    Thanks for taking care of it

    RequestHandlingTest.php:252 Reply

    Done

    RequestHandlingTest.php:264 Reply

    Done

    RequestHandlingTest.php:265 Reply

    Done

    RequestHandlingTest.php:346 Reply

    Done

    RequestHandlingTest.php:354 Reply

    Done
  12. core-ci voted on patch set 11 V +1 04/28/22, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26589

  13. waldhacker uploaded patch set 12 04/28/22, 13:53

  14. core-ci voted on patch set 12 V +1 04/28/22, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26597

  15. waldhacker uploaded patch set 13 04/28/22, 14:27

  16. core-ci voted on patch set 13 V +1 04/28/22, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26605

  17. Björn Jacob voted on patch set 13 V +1 CR +1 05/04/22, 09:48

  18. Oliver Klee voted on patch set 13 V +1 05/04/22, 11:02

  19. Oliver Hader rebased onto patch set 14 06/03/22, 09:24

  20. Oliver Hader voted on patch set 14 V +1 CR +1 06/03/22, 09:24

  21. Oliver Hader commented on patch set 14 06/03/22, 09:24

    Rebased, to check whether recent type changes etc. are still in line with this change.
  22. core-ci voted on patch set 14 V +1 06/03/22, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27671

  23. Oliver Klee voted on patch set 14 V +1 06/03/22, 09:34

  24. Stefan Bürk voted on patch set 14 V +2 CR +2 06/03/22, 17:21

  25. Stefan Bürk merged patch set 15 06/03/22, 17:21