73722[TASK] Add functional tests to test the caching behavior of ext:form
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Hader +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Oliver Hader +1
- core-ci +1 CI
Issues 2
Files 26
- typo3/sysext/form/Tests/Functional/Fixtures/Frontend/ContentRenderer.typoscriptnew+17 −0
- typo3/sysext/form/Tests/Functional/Framework/FormHandling/FormData.phpnew+185 −0
- typo3/sysext/form/Tests/Functional/Framework/FormHandling/FormDataFactory.phpnew+94 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Classes/Controller/FormCachingTestsController.phpnew+38 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Configuration/TCA/Overrides/sys_template.phpnew+5 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Configuration/TCA/Overrides/tt_content.phpnew+7 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Configuration/TypoScript/setup.typoscriptnew+177 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Configuration/Yaml/FormSetup.yamlnew+6 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Configuration/Services.yamlnew+8 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Resources/Private/Form/Form1.form.yamlnew+43 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Resources/Private/Form/Form2.form.yamlnew+43 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Resources/Private/Form/Form3.form.yamlnew+43 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Resources/Private/Templates/FormCachingTests/SomePerform.htmlnew+2 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Resources/Private/Templates/FormCachingTests/SomeRender.htmlnew+2 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Resources/Private/Templates/FormFluidtemplate.htmlnew+2 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/composer.jsonnew+16 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/ext_emconf.phpnew+15 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/ext_localconf.phpnew+42 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Forms/MultistepTestForm.form.yamlnew+42 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Forms/SinglestepTestForm.form.yamlnew+38 −0
Show 6 more files
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/formSetup.typoscriptnew+7 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/FormSetup.yamlnew+6 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/OnePageWithMultipleFormIntegrationsScenario.yamlnew+44 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/AbstractRequestHandlingTest.php4new+179 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/RequestHandlingTest.php10new+357 −0
- composer.json+1 −0
Review log 2741
Show 916 earlier messages
-
waldhacker uploaded patch set 1 02/25/22, 17:10
-
core-ci voted on patch set 1 V -1 02/25/22, 17:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24299
-
Björn Jacob commented on patch set 1 02/25/22, 19:46
IMHO this has to be related to #93887 and not to the issue #70... -
waldhacker updated the commit message in patch set 2 02/26/22, 08:03
-
core-ci voted on patch set 2 V +1 02/26/22, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24314
-
Oliver Hader uploaded patch set 3 02/26/22, 09:40
-
core-ci voted on patch set 3 V -1 02/26/22, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24316
-
Oliver Hader uploaded patch set 4 02/26/22, 09:51
-
core-ci voted on patch set 4 V +1 02/26/22, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24317
-
waldhacker uploaded patch set 5 02/26/22, 12:39
-
core-ci voted on patch set 5 V +1 02/26/22, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24321
-
waldhacker commented on patch set 6 02/26/22, 12:48
Published edit on patch set 5. -
core-ci voted on patch set 6 V +1 02/26/22, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24322
-
waldhacker uploaded patch set 7 02/26/22, 17:43
-
core-ci voted on patch set 7 V +1 02/26/22, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24336
-
Stefan Bürk commented on patch set 7 CR -1 03/04/22, 19:41
on it
-
Stefan Bürk uploaded patch set 8 03/04/22, 20:00
-
core-ci voted on patch set 8 V +1 03/04/22, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24586
-
Stefan Bürk commented on patch set 8 CR -1 03/04/22, 20:11
See comment for typo3/sysext/form/Tests/Functional/RequestHandling/AbstractRequestHandlingTest.phpAbstractRequestHandlingTest.php:193Not a good way to "simply" copy tf methods to core. Opening a PR in tf before hand would be the better way. Same for "retrieveFrontendSubRequestResult()" below. However, this has been added to testing-framework now. These methods should be removed and InternalRequest() propely filled. See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73767 This adds tests for POST, PUT, PACH and DELETE requests with data submission. -
Christian Kuhn commented on patch set 8 03/04/22, 20:33
AbstractRequestHandlingTest.php:193Replyagreed. we just fixed that in TF (v6, too), so it should be fine to not override her. -
Stefan Bürk uploaded patch set 9 03/04/22, 23:27
-
core-ci voted on patch set 9 V +1 03/04/22, 23:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24595
-
Stefan Bürk uploaded patch set 10 03/04/22, 23:53
-
Stefan Bürk commented on patch set 10 03/05/22, 00:00
DataPusher.php:27Can we find a name which match properly what this class does or is for ? It do not push anything anyware. It just holds the data to be "used" or transformed eventually. Added a "class comment" but maybe can be changed accordingly.AbstractRequestHandlingTest.php:193ReplyDoneRequestHandlingTest.php:252superflous - not used later and do not serve any checks/data prepartion.RequestHandlingTest.php:264unusedRequestHandlingTest.php:265unusedRequestHandlingTest.php:346unused - can be removed.RequestHandlingTest.php:354unused - can be removed. -
core-ci voted on patch set 10 V +1 03/05/22, 00:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24598
-
waldhacker uploaded patch set 11 04/28/22, 13:22
-
waldhacker commented on patch set 11 04/28/22, 13:27
DataPusher.php:27ReplyDoneAbstractRequestHandlingTest.php:193ReplyThanks for taking care of itRequestHandlingTest.php:252ReplyDoneRequestHandlingTest.php:264ReplyDoneRequestHandlingTest.php:265ReplyDoneRequestHandlingTest.php:346ReplyDoneRequestHandlingTest.php:354ReplyDone -
core-ci voted on patch set 11 V +1 04/28/22, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26589
-
waldhacker uploaded patch set 12 04/28/22, 13:53
-
core-ci voted on patch set 12 V +1 04/28/22, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26597
-
waldhacker uploaded patch set 13 04/28/22, 14:27
-
core-ci voted on patch set 13 V +1 04/28/22, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26605
-
Björn Jacob voted on patch set 13 V +1 CR +1 05/04/22, 09:48
-
Oliver Klee voted on patch set 13 V +1 05/04/22, 11:02
-
Oliver Hader rebased onto patch set 14 06/03/22, 09:24
-
Oliver Hader voted on patch set 14 V +1 CR +1 06/03/22, 09:24
-
Oliver Hader commented on patch set 14 06/03/22, 09:24
Rebased, to check whether recent type changes etc. are still in line with this change. -
core-ci voted on patch set 14 V +1 06/03/22, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27671
-
Oliver Klee voted on patch set 14 V +1 06/03/22, 09:34
-
Stefan Bürk voted on patch set 14 V +2 CR +2 06/03/22, 17:21
-
Stefan Bürk merged patch set 15 06/03/22, 17:21