Review main Merged

73725[FEATURE] Add page selector to Belog filter

Oli Bartsch CR +2 V +2 Normal +195 −25 updated 02/27/22, 11:18

Commit message

The filter in the Belog module is extended for a
new page selector (Database browser). Using the
new selector, one is able to filter logs by specific
page or even page trees, when using together
with the "depth" option.

Additionally, the modules' access is changed to
"user", which allows administrators to enable the
module for specific users or user groups. Non-admin
users however will never see global logs, but only
logs for pages they have access to. The user will
be informed by corresponding info boxes.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 13

Review log 1013

  1. Oli Bartsch uploaded patch set 1 02/25/22, 22:53

  2. core-ci voted on patch set 1 V +1 02/25/22, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24309

  3. Benjamin Franzke uploaded patch set 2 02/26/22, 08:41

  4. core-ci voted on patch set 2 V +1 02/26/22, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24315

  5. Stefan Bürk commented on patch set 2 V -1 02/26/22, 18:17

    If I enter a page id manually, the filter works. If I use the Link/PageBrowser and select a page, I got a JavaScript error in the webconsole, page filter field is empty and not taken into account (fall back to page 0). ``` The specified value "undefined" cannot be parsed, or is out of range. ```
  6. Benjamin Franzke commented on patch set 2 V 0 CR 0 02/27/22, 10:34

    Reply

    Oh, right, choosing e.g page 30 via the right-side of the elementbrowser returns "pages_30", while the the inline-link-icon in the elementbrowser-page-tree returns only "30". then .split('_') returns an array with only one element and result[1] is obviously undefined.
  7. Oli Bartsch uploaded patch set 3 02/27/22, 10:41

  8. Oli Bartsch commented on patch set 3 02/27/22, 10:43

    Reply

    You're right, this only happened when selecting a page in the page tree. Has been fixed (also in the scheduler related code where the same bug exists).
  9. core-ci voted on patch set 3 V +1 02/27/22, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24354

  10. Benjamin Franzke voted on patch set 3 V +1 CR +1 02/27/22, 10:52

  11. Stefan Bürk voted on patch set 3 V +1 CR +1 02/27/22, 11:11

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 02/27/22, 11:18

  13. Oli Bartsch merged patch set 4 02/27/22, 11:18