73725[FEATURE] Add page selector to Belog filter
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 13
- Build/Sources/Sass/typo3/_history.scss+6 −0
- Build/Sources/TypeScript/belog/backend-log.ts+39 −0
- Build/Sources/TypeScript/scheduler/scheduler.ts+1 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/belog/Classes/Controller/BackendLogController.php+30 −11
- typo3/sysext/belog/Configuration/Backend/Modules.php+1 −1
- typo3/sysext/belog/Resources/Private/Language/locallang.xlf+15 −0
- typo3/sysext/belog/Resources/Private/Partials/Content/Filter.html+35 −1
- typo3/sysext/belog/Resources/Private/Partials/Content/LogEntries.html+16 −2
- typo3/sysext/belog/Resources/Private/Templates/BackendLog/List.html+20 −5
- typo3/sysext/belog/Resources/Public/JavaScript/backend-log.js+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97051-FilterLogsByPageInLogModule.rstnew+29 −0
- typo3/sysext/scheduler/Resources/Public/JavaScript/scheduler.js+1 −1
Review log 1013
-
Oli Bartsch uploaded patch set 1 02/25/22, 22:53
-
core-ci voted on patch set 1 V +1 02/25/22, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24309
-
Benjamin Franzke uploaded patch set 2 02/26/22, 08:41
-
core-ci voted on patch set 2 V +1 02/26/22, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24315
-
Stefan Bürk commented on patch set 2 V -1 02/26/22, 18:17
If I enter a page id manually, the filter works. If I use the Link/PageBrowser and select a page, I got a JavaScript error in the webconsole, page filter field is empty and not taken into account (fall back to page 0). ``` The specified value "undefined" cannot be parsed, or is out of range. ``` -
Benjamin Franzke commented on patch set 2 V 0 CR 0 02/27/22, 10:34
Reply
Oh, right, choosing e.g page 30 via the right-side of the elementbrowser returns "pages_30", while the the inline-link-icon in the elementbrowser-page-tree returns only "30". then .split('_') returns an array with only one element and result[1] is obviously undefined. -
Oli Bartsch uploaded patch set 3 02/27/22, 10:41
-
Oli Bartsch commented on patch set 3 02/27/22, 10:43
Reply
You're right, this only happened when selecting a page in the page tree. Has been fixed (also in the scheduler related code where the same bug exists). -
core-ci voted on patch set 3 V +1 02/27/22, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24354
-
Benjamin Franzke voted on patch set 3 V +1 CR +1 02/27/22, 10:52
-
Stefan Bürk voted on patch set 3 V +1 CR +1 02/27/22, 11:11
-
Oli Bartsch voted on patch set 3 V +2 CR +2 02/27/22, 11:18
-
Oli Bartsch merged patch set 4 02/27/22, 11:18