Review main Merged

73727[TASK] Raise "composer/composer" and "friendsofphp/php-cs-fixer"

Stefan Bürk CR +2 V +2 Hard +172 −144 updated 03/02/22, 08:28

Commit message

This patch raises two dev dependencies to do one more
footstep towards symfony 6.x component raises. After
this patch codeception is the only package which blocks
symfony raise.

raised packages:

* composer/composer:^2.2.7: includes a opened requirement
  definition for composer/xdebug-helper which will not
  interfere with friendsofphp/php-cs-fixer >3.4
* friendsofphp/php-cs-fixer:^3.6.0: latest php-cs-fixer
  version which allows symfony 6.x components if needed

used commands:

> composer req --dev -W \
    "composer/composer":"^2.2.7" \
    "friendsofphp/php-cs-fixer":"^3.6.0"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1420

  1. Stefan Bürk uploaded patch set 1 02/26/22, 17:57

  2. Stefan Bürk updated the commit message in patch set 2 02/26/22, 17:58

  3. core-ci voted on patch set 1 V -1 02/26/22, 18:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24337

  4. Oliver Klee voted on patch set 2 CR +1 02/26/22, 18:06

  5. Stefan Bürk updated the commit message in patch set 3 02/26/22, 18:07

  6. core-ci voted on patch set 3 V -1 02/26/22, 18:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24339

  7. core-ci voted on patch set 2 V -1 02/26/22, 18:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24338

  8. Stefan Bürk commented on patch set 3 CR -1 02/26/22, 19:57

    Needs to have following patch merged first: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73729 Decided to handle this in a dedicated pre-patch as the related doctrine/lexer is a core dependency and not only a dev dependency.
  9. Stefan Bürk uploaded patch set 4 02/28/22, 20:23

  10. core-ci voted on patch set 4 V -1 02/28/22, 20:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24391

  11. Stefan Bürk voted on patch set 4 CR -1 02/28/22, 20:44

  12. Stefan Bürk uploaded patch set 5 03/01/22, 18:42

  13. core-ci voted on patch set 5 V +1 03/01/22, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24414

  14. Oliver Klee voted on patch set 5 CR +1 03/01/22, 18:53

  15. Stefan Bürk updated the commit message in patch set 6 03/01/22, 18:54

  16. core-ci voted on patch set 6 V +1 03/01/22, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24415

  17. Oliver Klee voted on patch set 6 CR +1 03/01/22, 19:30

  18. Georg Ringer voted on patch set 6 V +1 CR +1 03/02/22, 07:04

  19. Benni Mack voted on patch set 6 V +2 CR +2 03/02/22, 08:28

  20. Benni Mack merged patch set 7 03/02/22, 08:28