Review main Merged

73729[BUGFIX] Raise doctrine/lexer:"^1.2.2"

Stefan Bürk CR +2 V +2 Easy +19 −18 updated 02/27/22, 15:04

Commit message

doctrine/lexer has released a new minor version with changed
method docblocks, which now emits phpstan errors because of
incompatible types.

This patch raises the minor version for development and core
usage and adding phpstan ignore pattern to the baseline file
until doctrine/lexer has fixed the incompatible state. This
is a dedicated preparation to raise other dev dependencies.

Issue has been reported to the corresponding github repository:
https://github.com/doctrine/lexer/issues/62

used commands:

> composer req doctrine/lexer:"^1.2.2"
> composer req doctrine/lexer:"^1.2.2" \
  --no-update -d typo3/sysext/core
> Build/Scripts/runTests.sh \
  -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 810

  1. Stefan Bürk uploaded patch set 1 02/26/22, 19:46

  2. core-ci voted on patch set 1 V +1 02/26/22, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24342

  3. Oliver Klee voted on patch set 1 CR +1 02/26/22, 20:42

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 02/26/22, 21:05

  5. Stefan Bürk rebased onto patch set 2 02/27/22, 14:48

  6. core-ci voted on patch set 2 V +1 02/27/22, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24373

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 02/27/22, 15:01

  8. Nikita Hovratov voted on patch set 2 V +1 CR +1 02/27/22, 15:02

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 02/27/22, 15:04

  10. Andreas Kienast merged patch set 3 02/27/22, 15:04